projects
/
linux-block.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
5b394b2
)
rtc: rtc-mrst: Replace mdelay() with msleep() in mrst_read_time()
author
Jia-Ju Bai
<baijiaju1990@gmail.com>
Mon, 30 Jul 2018 13:59:03 +0000
(21:59 +0800)
committer
Alexandre Belloni
<alexandre.belloni@bootlin.com>
Mon, 27 Aug 2018 20:51:54 +0000
(22:51 +0200)
mrst_read_time() is never called in atomic context.
It calls mdelay() to busily wait, which is not necessary.
mdelay() can be replaced with msleep().
This is found by a static analysis tool named DCNS written by myself.
Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
drivers/rtc/rtc-mrst.c
patch
|
blob
|
blame
|
history
diff --git
a/drivers/rtc/rtc-mrst.c
b/drivers/rtc/rtc-mrst.c
index 1925aaf09093713326553740db6db4358eb9fb51..bf2d7af03d075eac790978edff6331654771d803 100644
(file)
--- a/
drivers/rtc/rtc-mrst.c
+++ b/
drivers/rtc/rtc-mrst.c
@@
-90,7
+90,7
@@
static int mrst_read_time(struct device *dev, struct rtc_time *time)
unsigned long flags;
if (vrtc_is_updating())
- m
delay
(20);
+ m
sleep
(20);
spin_lock_irqsave(&rtc_lock, flags);
time->tm_sec = vrtc_cmos_read(RTC_SECONDS);