powerpc/83xx: Use sizeof correct type when ioremapping
authorDan Carpenter <dan.carpenter@oracle.com>
Wed, 28 Jun 2017 11:49:07 +0000 (14:49 +0300)
committerMichael Ellerman <mpe@ellerman.id.au>
Thu, 31 Aug 2017 04:26:05 +0000 (14:26 +1000)
There is a cut and paste error here so we use sizeof(struct mpc83xx_pmc)
to remap the memory for "clock_regs". That sizeof() is 20 bytes and we
only need to remap 12 bytes. It presumably doesn't affect run time too
much...

I changed them to both use sizeof(*variable_name) because that's the
preferred kernel style these days.

Fixes: d49747bdfb2d ("powerpc/mpc83xx: Power Management support")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
[mpe: It will map at least one page anyway, but still a good cleanup]
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
arch/powerpc/platforms/83xx/suspend.c

index 978b85bb3233e55a78ea671629a07963d62e5fb3..7fa3e197871aa82b62c1aa9ff3a333f4d3ba0505 100644 (file)
@@ -361,7 +361,7 @@ static int pmc_probe(struct platform_device *ofdev)
                        return -EBUSY;
        }
 
-       pmc_regs = ioremap(res.start, sizeof(struct mpc83xx_pmc));
+       pmc_regs = ioremap(res.start, sizeof(*pmc_regs));
 
        if (!pmc_regs) {
                ret = -ENOMEM;
@@ -374,7 +374,7 @@ static int pmc_probe(struct platform_device *ofdev)
                goto out_pmc;
        }
 
-       clock_regs = ioremap(res.start, sizeof(struct mpc83xx_pmc));
+       clock_regs = ioremap(res.start, sizeof(*clock_regs));
 
        if (!clock_regs) {
                ret = -ENOMEM;