mm/damon/sysfs-schemes: avoid Wformat-security warning on damon_sysfs_access_pattern_...
authorSeongJae Park <sj@kernel.org>
Mon, 10 Mar 2025 16:50:09 +0000 (09:50 -0700)
committerAndrew Morton <akpm@linux-foundation.org>
Tue, 18 Mar 2025 05:07:01 +0000 (22:07 -0700)
When -Wformat-security is given, compiler warns as a potential security
issue on damon_sysfs_access_pattern_add_range_dir() as below:

    mm/damon/sysfs-schemes.c: In function `damon_sysfs_access_pattern_add_range_dir':
    mm/damon/sysfs-schemes.c:1503:25: warning: format not a string literal and no format arguments [-Wformat-security]
     1503 |                         &access_pattern->kobj, name);
          |                         ^

Fix it by using "%s" as the format and the name as the argument.

Link: https://lkml.kernel.org/r/20250310165009.652491-1-sj@kernel.org
Fixes: 7e84b1f8212a ("mm/damon/sysfs: support DAMON-based Operation Schemes")
Signed-off-by: SeongJae Park <sj@kernel.org>
Cc: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
mm/damon/sysfs-schemes.c

index 985cfc750a905a2c8d2eba174cb60028bc3a10d0..5023f2b690d678571e3fe89e81979f5af30ed54e 100644 (file)
@@ -1471,7 +1471,7 @@ static int damon_sysfs_access_pattern_add_range_dir(
        if (!range)
                return -ENOMEM;
        err = kobject_init_and_add(&range->kobj, &damon_sysfs_ul_range_ktype,
-                       &access_pattern->kobj, name);
+                       &access_pattern->kobj, "%s", name);
        if (err)
                kobject_put(&range->kobj);
        else