ipc: mqueue: fix possible memory leak in init_mqueue_fs()
authorHangyu Hua <hbh25y@gmail.com>
Fri, 15 Jul 2022 06:23:01 +0000 (14:23 +0800)
committerEric W. Biederman <ebiederm@xmission.com>
Tue, 19 Jul 2022 22:17:35 +0000 (17:17 -0500)
commit db7cfc380900 ("ipc: Free mq_sysctls if ipc namespace creation
failed")

Here's a similar memory leak to the one fixed by the patch above.
retire_mq_sysctls need to be called when init_mqueue_fs fails after
setup_mq_sysctls.

Fixes: dc55e35f9e81 ("ipc: Store mqueue sysctls in the ipc namespace")
Signed-off-by: Hangyu Hua <hbh25y@gmail.com>
Link: https://lkml.kernel.org/r/20220715062301.19311-1-hbh25y@gmail.com
Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
ipc/mqueue.c

index 12ad7860bb88f16da9a75e27b4dc8a14b662dafc..83370fef8879665270a699bb6629787171570f2d 100644 (file)
@@ -1746,6 +1746,7 @@ out_filesystem:
        unregister_filesystem(&mqueue_fs_type);
 out_sysctl:
        kmem_cache_destroy(mqueue_inode_cachep);
+       retire_mq_sysctls(&init_ipc_ns);
        return error;
 }