octeontx2-af: Change block parameter to const pointer in get_lf_str_list
authorRiyan Dhiman <riyandhiman14@gmail.com>
Tue, 1 Oct 2024 11:05:43 +0000 (16:35 +0530)
committerJakub Kicinski <kuba@kernel.org>
Fri, 4 Oct 2024 18:12:28 +0000 (11:12 -0700)
Convert struct rvu_block block to const struct rvu_block *block in
get_lf_str_list() function parameter. This improves efficiency by
avoiding structure copying and reflects the function's read-only
access to block.

Signed-off-by: Riyan Dhiman <riyandhiman14@gmail.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20241001110542.5404-2-riyandhiman14@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/marvell/octeontx2/af/rvu_debugfs.c

index 87ba77e5026a024fa38b39c2b10fbfbfd581fc84..8c700ee4a82b4da76972fd11b5ef2a74ee89704a 100644 (file)
@@ -663,16 +663,16 @@ static ssize_t rvu_dbg_lmtst_map_table_display(struct file *filp,
 
 RVU_DEBUG_FOPS(lmtst_map_table, lmtst_map_table_display, NULL);
 
-static void get_lf_str_list(struct rvu_block block, int pcifunc,
+static void get_lf_str_list(const struct rvu_block *block, int pcifunc,
                            char *lfs)
 {
-       int lf = 0, seq = 0, len = 0, prev_lf = block.lf.max;
+       int lf = 0, seq = 0, len = 0, prev_lf = block->lf.max;
 
-       for_each_set_bit(lf, block.lf.bmap, block.lf.max) {
-               if (lf >= block.lf.max)
+       for_each_set_bit(lf, block->lf.bmap, block->lf.max) {
+               if (lf >= block->lf.max)
                        break;
 
-               if (block.fn_map[lf] != pcifunc)
+               if (block->fn_map[lf] != pcifunc)
                        continue;
 
                if (lf == prev_lf + 1) {
@@ -719,7 +719,7 @@ static int get_max_column_width(struct rvu *rvu)
                                if (!strlen(block.name))
                                        continue;
 
-                               get_lf_str_list(block, pcifunc, buf);
+                               get_lf_str_list(&block, pcifunc, buf);
                                if (lf_str_size <= strlen(buf))
                                        lf_str_size = strlen(buf) + 1;
                        }
@@ -803,7 +803,7 @@ static ssize_t rvu_dbg_rsrc_attach_status(struct file *filp,
                                        continue;
                                len = 0;
                                lfs[len] = '\0';
-                               get_lf_str_list(block, pcifunc, lfs);
+                               get_lf_str_list(&block, pcifunc, lfs);
                                if (strlen(lfs))
                                        flag = 1;