ipmi:ssif: Add check for kstrdup

Add check for the return value of kstrdup() and return the error
if it fails in order to avoid NULL pointer dereference.

Fixes: c4436c9149c5 ("ipmi_ssif: avoid registering duplicate ssif interface")
Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
Message-Id: <20230619092802.35384-1-jiasheng@iscas.ac.cn>
Signed-off-by: Corey Minyard <minyard@acm.org>

diff --git a/drivers/char/ipmi/ipmi_ssif.c b/drivers/char/ipmi/ipmi_ssif.c
index c6c9bcf6bf55c9602dd3b579f3f70d5773dc98e9..07cfde579cfb9a2454976f8356024ca91677fa85 100644 (file)
--- a/drivers/char/ipmi/ipmi_ssif.c
+++ b/drivers/char/ipmi/ipmi_ssif.c
@@ -1600,6 +1600,11 @@ static int ssif_add_infos(struct i2c_client *client)
        info->addr_src = SI_ACPI;
        info->client = client;
        info->adapter_name = kstrdup(client->adapter->name, GFP_KERNEL);
+       if (!info->adapter_name) {
+               kfree(info);
+               return -ENOMEM;
+       }
+
        info->binfo.addr = client->addr;
        list_add_tail(&info->link, &ssif_infos);
        return 0;