ALSA: trident: Use pure devres PCI
authorPhilipp Stanner <phasta@kernel.org>
Wed, 23 Apr 2025 07:53:34 +0000 (09:53 +0200)
committerTakashi Iwai <tiwai@suse.de>
Thu, 24 Apr 2025 07:21:34 +0000 (09:21 +0200)
pci_request_regions() is a hybrid function which becomes managed if
pcim_enable_device() was called before. This hybrid nature is deprecated
and should not be used anymore.

In addition, the request function's name parameter should describe the
driver, not the device.

Replace pci_request_regions() with the always-managed function
pcim_request_all_regions().

Signed-off-by: Philipp Stanner <phasta@kernel.org>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Link: https://patch.msgid.link/20250423075346.45907-17-phasta@kernel.org
sound/pci/trident/trident_main.c

index 8039f445bee22e5c048dc0eceda1e92d2cc81905..4e16b79d6584b10d2482474db76c4ce26fcf3961 100644 (file)
@@ -3533,7 +3533,7 @@ int snd_trident_create(struct snd_card *card,
        trident->midi_port = TRID_REG(trident, T4D_MPU401_BASE);
        pci_set_master(pci);
 
-       err = pci_request_regions(pci, "Trident Audio");
+       err = pcim_request_all_regions(pci, "Trident Audio");
        if (err < 0)
                return err;
        trident->port = pci_resource_start(pci, 0);