drm/amdgpu/amdgpu: use "*" adjacent to data name
authorDeepak R Varma <mh12gx2825@gmail.com>
Mon, 2 Nov 2020 19:37:12 +0000 (01:07 +0530)
committerAlex Deucher <alexander.deucher@amd.com>
Mon, 2 Nov 2020 20:35:50 +0000 (15:35 -0500)
When declaring pointer data, the "*" symbol should be used adjacent to
the data name as per the coding standards. This resolves following
issues reported by checkpatch script:
ERROR: "foo *   bar" should be "foo *bar"
ERROR: "foo * bar" should be "foo *bar"
ERROR: "foo*            bar" should be "foo *bar"
ERROR: "(foo*)" should be "(foo *)"

Signed-off-by: Deepak R Varma <mh12gx2825@gmail.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c
drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c
drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c
drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c
drivers/gpu/drm/amd/amdgpu/amdgpu_test.c
drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c

index 469352e2d6ecffff3dfb36480c0ae0c5f3c9eb8e..86add0f4ea4d0a9b49506f7f202db4888cc57058 100644 (file)
@@ -1401,7 +1401,7 @@ static ATOM_VOLTAGE_OBJECT_V3 *amdgpu_atombios_lookup_voltage_object_v3(ATOM_VOL
 {
        u32 size = le16_to_cpu(v3->sHeader.usStructureSize);
        u32 offset = offsetof(ATOM_VOLTAGE_OBJECT_INFO_V3_1, asVoltageObj[0]);
-       u8 *start = (u8*)v3;
+       u8 *start = (u8 *)v3;
 
        while (offset < size) {
                ATOM_VOLTAGE_OBJECT_V3 *vo = (ATOM_VOLTAGE_OBJECT_V3 *)(start + offset);
index 09cd2d228fdf6941aaa8c39a8b4516b7006fadef..306077884a6794e5709efcefea25dea0554b3a33 100644 (file)
@@ -70,7 +70,7 @@ int amdgpu_atomfirmware_allocate_fb_scratch(struct amdgpu_device *adev)
        struct atom_context *ctx = adev->mode_info.atom_context;
        int index = get_index_into_master_table(atom_master_list_of_data_tables_v2_1,
                                                vram_usagebyfirmware);
-       struct vram_usagebyfirmware_v2_1 *      firmware_usage;
+       struct vram_usagebyfirmware_v2_1 *firmware_usage;
        uint32_t start_addr, size;
        uint16_t data_offset;
        int usage_bytes = 0;
index 309464a8c06bf43e2fdb304e9e79ab1508baa60c..79342976fa76d0f4ed179f05fe027a71e841563c 100644 (file)
@@ -1461,7 +1461,7 @@ int amdgpu_cs_fence_to_handle_ioctl(struct drm_device *dev, void *data,
                dma_fence_put(fence);
                if (r)
                        return r;
-               r = drm_syncobj_get_fd(syncobj, (int*)&info->out.handle);
+               r = drm_syncobj_get_fd(syncobj, (int *)&info->out.handle);
                drm_syncobj_put(syncobj);
                return r;
 
index a03398c8734441d38773e48b0b572d4412449b42..0350205c48974e0dfafd81c2f14b365ebbff7e91 100644 (file)
@@ -450,7 +450,7 @@ int amdgpu_ctx_put(struct amdgpu_ctx *ctx)
 
 void amdgpu_ctx_add_fence(struct amdgpu_ctx *ctx,
                          struct drm_sched_entity *entity,
-                         struct dma_fence *fence, uint64_thandle)
+                         struct dma_fence *fence, uint64_t *handle)
 {
        struct amdgpu_ctx_entity *centity = to_amdgpu_ctx_entity(entity);
        uint64_t seq = centity->sequence;
index 2caea7e340ea187dfcda4372257bd30cc4a78698..c3457d675edb0e6c45673b0f0a0fbb81b252d1a0 100644 (file)
@@ -838,7 +838,7 @@ int psp_xgmi_get_hive_id(struct psp_context *psp, uint64_t *hive_id)
        struct ta_xgmi_shared_memory *xgmi_cmd;
        int ret;
 
-       xgmi_cmd = (struct ta_xgmi_shared_memory*)psp->xgmi_context.xgmi_shared_buf;
+       xgmi_cmd = (struct ta_xgmi_shared_memory *)psp->xgmi_context.xgmi_shared_buf;
        memset(xgmi_cmd, 0, sizeof(struct ta_xgmi_shared_memory));
 
        xgmi_cmd->cmd_id = TA_COMMAND_XGMI__GET_HIVE_ID;
@@ -858,7 +858,7 @@ int psp_xgmi_get_node_id(struct psp_context *psp, uint64_t *node_id)
        struct ta_xgmi_shared_memory *xgmi_cmd;
        int ret;
 
-       xgmi_cmd = (struct ta_xgmi_shared_memory*)psp->xgmi_context.xgmi_shared_buf;
+       xgmi_cmd = (struct ta_xgmi_shared_memory *)psp->xgmi_context.xgmi_shared_buf;
        memset(xgmi_cmd, 0, sizeof(struct ta_xgmi_shared_memory));
 
        xgmi_cmd->cmd_id = TA_COMMAND_XGMI__GET_NODE_ID;
@@ -886,7 +886,7 @@ int psp_xgmi_get_topology_info(struct psp_context *psp,
        if (!topology || topology->num_nodes > TA_XGMI__MAX_CONNECTED_NODES)
                return -EINVAL;
 
-       xgmi_cmd = (struct ta_xgmi_shared_memory*)psp->xgmi_context.xgmi_shared_buf;
+       xgmi_cmd = (struct ta_xgmi_shared_memory *)psp->xgmi_context.xgmi_shared_buf;
        memset(xgmi_cmd, 0, sizeof(struct ta_xgmi_shared_memory));
 
        /* Fill in the shared memory with topology information as input */
@@ -930,7 +930,7 @@ int psp_xgmi_set_topology_info(struct psp_context *psp,
        if (!topology || topology->num_nodes > TA_XGMI__MAX_CONNECTED_NODES)
                return -EINVAL;
 
-       xgmi_cmd = (struct ta_xgmi_shared_memory*)psp->xgmi_context.xgmi_shared_buf;
+       xgmi_cmd = (struct ta_xgmi_shared_memory *)psp->xgmi_context.xgmi_shared_buf;
        memset(xgmi_cmd, 0, sizeof(struct ta_xgmi_shared_memory));
 
        topology_info_input = &xgmi_cmd->xgmi_in_message.get_topology_info;
@@ -994,7 +994,7 @@ static int psp_ras_load(struct psp_context *psp)
        ret = psp_cmd_submit_buf(psp, NULL, cmd,
                        psp->fence_buf_mc_addr);
 
-       ras_cmd = (struct ta_ras_shared_memory*)psp->ras.ras_shared_buf;
+       ras_cmd = (struct ta_ras_shared_memory *)psp->ras.ras_shared_buf;
 
        if (!ret) {
                psp->ras.session_id = cmd->resp.session_id;
@@ -1916,7 +1916,7 @@ static int psp_execute_np_fw_load(struct psp_context *psp,
 static int psp_load_smu_fw(struct psp_context *psp)
 {
        int ret;
-       struct amdgpu_deviceadev = psp->adev;
+       struct amdgpu_device *adev = psp->adev;
        struct amdgpu_firmware_info *ucode =
                        &adev->firmware.ucode[AMDGPU_UCODE_ID_SMC];
        struct amdgpu_ras *ras = psp->ras.ras;
@@ -1982,7 +1982,7 @@ static int psp_np_fw_load(struct psp_context *psp)
 {
        int i, ret;
        struct amdgpu_firmware_info *ucode;
-       struct amdgpu_deviceadev = psp->adev;
+       struct amdgpu_device *adev = psp->adev;
 
        if (psp->autoload_supported &&
            !psp->pmfw_centralized_cstate_management) {
index 15ee13c3bd9e191e28eba342db182d82606cc654..2697b250dc3269633a4bd54054a847a4f796cfa5 100644 (file)
@@ -396,7 +396,7 @@ static ssize_t amdgpu_debugfs_ring_read(struct file *f, char __user *buf,
                        return result;
 
                value = ring->ring[(*pos - 12)/4];
-               r = put_user(value, (uint32_t*)buf);
+               r = put_user(value, (uint32_t *)buf);
                if (r)
                        return r;
                buf += 4;
index 2f4d5ca9894fc361ee72bd5b168fc89102ceac42..6042b3b81a4c9a17d0120bee31274050080c2a0f 100644 (file)
@@ -157,10 +157,10 @@ static void amdgpu_do_test_moves(struct amdgpu_device *adev)
                                          i, *vram_start, gart_start,
                                          (unsigned long long)
                                          (gart_addr - adev->gmc.gart_start +
-                                          (void*)gart_start - gtt_map),
+                                          (void *)gart_start - gtt_map),
                                          (unsigned long long)
                                          (vram_addr - adev->gmc.vram_start +
-                                          (void*)gart_start - gtt_map));
+                                          (void *)gart_start - gtt_map));
                                amdgpu_bo_kunmap(vram_obj);
                                goto out_lclean_unpin;
                        }
@@ -203,10 +203,10 @@ static void amdgpu_do_test_moves(struct amdgpu_device *adev)
                                          i, *gart_start, vram_start,
                                          (unsigned long long)
                                          (vram_addr - adev->gmc.vram_start +
-                                          (void*)vram_start - vram_map),
+                                          (void *)vram_start - vram_map),
                                          (unsigned long long)
                                          (gart_addr - adev->gmc.gart_start +
-                                          (void*)vram_start - vram_map));
+                                          (void *)vram_start - vram_map));
                                amdgpu_bo_kunmap(gtt_obj[i]);
                                goto out_lclean_unpin;
                        }
index 7daded325c3d5c5e050796881bc93f6cf909e6e8..69ebd07f3eeee8a8e752f9e23c480674529a9f30 100644 (file)
@@ -1115,7 +1115,7 @@ static int amdgpu_ttm_backend_bind(struct ttm_tt *ttm,
                                   struct ttm_resource *bo_mem)
 {
        struct amdgpu_device *adev = amdgpu_ttm_adev(ttm->bdev);
-       struct amdgpu_ttm_tt *gtt = (void*)ttm;
+       struct amdgpu_ttm_tt *gtt = (void *)ttm;
        uint64_t flags;
        int r = 0;
 
@@ -1167,7 +1167,7 @@ int amdgpu_ttm_alloc_gart(struct ttm_buffer_object *bo)
 {
        struct amdgpu_device *adev = amdgpu_ttm_adev(bo->bdev);
        struct ttm_operation_ctx ctx = { false, false };
-       struct amdgpu_ttm_tt *gtt = (void*)bo->ttm;
+       struct amdgpu_ttm_tt *gtt = (void *)bo->ttm;
        struct ttm_resource tmp;
        struct ttm_placement placement;
        struct ttm_place placements;
@@ -1427,7 +1427,7 @@ int amdgpu_ttm_tt_set_userptr(struct ttm_buffer_object *bo,
                        return -ENOMEM;
        }
 
-       gtt = (void*)bo->ttm;
+       gtt = (void *)bo->ttm;
        gtt->userptr = addr;
        gtt->userflags = flags;
 
index 1c9476a060d7ff7e81264ff89f8b9de2c233ad62..2b7c90b7a712199c7b06fde0ade1d54378a05bd4 100644 (file)
@@ -588,8 +588,8 @@ static int amdgpu_ucode_patch_jt(struct amdgpu_firmware_info *ucode,
 {
        const struct gfx_firmware_header_v1_0 *header = NULL;
        const struct common_firmware_header *comm_hdr = NULL;
-       uint8_tsrc_addr = NULL;
-       uint8_tdst_addr = NULL;
+       uint8_t *src_addr = NULL;
+       uint8_t *dst_addr = NULL;
 
        if (NULL == ucode->fw)
                return 0;