net/sched: use min() macro instead of doing it manually
authorYang Li <yang.lee@linux.alibaba.com>
Tue, 21 Dec 2021 01:14:55 +0000 (09:14 +0800)
committerDavid S. Miller <davem@davemloft.net>
Tue, 21 Dec 2021 10:16:47 +0000 (10:16 +0000)
Fix following coccicheck warnings:
./net/sched/cls_api.c:3333:17-18: WARNING opportunity for min()
./net/sched/cls_api.c:3389:17-18: WARNING opportunity for min()
./net/sched/cls_api.c:3427:17-18: WARNING opportunity for min()

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/sched/cls_api.c

index e3e26d358c7fbead72bbec3a28976ee2736f233d..563b00481866bfe4506b26e7b47014779fb6b9a7 100644 (file)
@@ -3330,7 +3330,7 @@ err_unlock:
        up_read(&block->cb_lock);
        if (take_rtnl)
                rtnl_unlock();
-       return ok_count < 0 ? ok_count : 0;
+       return min(ok_count, 0);
 }
 EXPORT_SYMBOL(tc_setup_cb_add);
 
@@ -3386,7 +3386,7 @@ err_unlock:
        up_read(&block->cb_lock);
        if (take_rtnl)
                rtnl_unlock();
-       return ok_count < 0 ? ok_count : 0;
+       return min(ok_count, 0);
 }
 EXPORT_SYMBOL(tc_setup_cb_replace);
 
@@ -3424,7 +3424,7 @@ retry:
        up_read(&block->cb_lock);
        if (take_rtnl)
                rtnl_unlock();
-       return ok_count < 0 ? ok_count : 0;
+       return min(ok_count, 0);
 }
 EXPORT_SYMBOL(tc_setup_cb_destroy);