drm/panel: remove return value of function drm_panel_add
authorBernard Zhao <bernard@vivo.com>
Sat, 1 Aug 2020 12:02:13 +0000 (20:02 +0800)
committerSam Ravnborg <sam@ravnborg.org>
Sun, 2 Aug 2020 06:59:06 +0000 (08:59 +0200)
The function "int drm_panel_add(struct drm_panel *panel)"
always returns 0, this return value is meaningless.
Also, there is no need to check return value which calls
"drm_panel_add and", error branch code will never run.

Signed-off-by: Bernard Zhao <bernard@vivo.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20200801120216.8488-1-bernard@vivo.com
44 files changed:
drivers/gpu/drm/drm_panel.c
drivers/gpu/drm/panel/panel-arm-versatile.c
drivers/gpu/drm/panel/panel-asus-z00t-tm5p5-n35596.c
drivers/gpu/drm/panel/panel-boe-himax8279d.c
drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c
drivers/gpu/drm/panel/panel-feixin-k101-im2ba02.c
drivers/gpu/drm/panel/panel-feiyang-fy07024di26a30d.c
drivers/gpu/drm/panel/panel-ilitek-ili9322.c
drivers/gpu/drm/panel/panel-ilitek-ili9881c.c
drivers/gpu/drm/panel/panel-innolux-p079zca.c
drivers/gpu/drm/panel/panel-jdi-lt070me05000.c
drivers/gpu/drm/panel/panel-kingdisplay-kd097d04.c
drivers/gpu/drm/panel/panel-lg-lb035q02.c
drivers/gpu/drm/panel/panel-lg-lg4573.c
drivers/gpu/drm/panel/panel-lvds.c
drivers/gpu/drm/panel/panel-nec-nl8048hl11.c
drivers/gpu/drm/panel/panel-novatek-nt35510.c
drivers/gpu/drm/panel/panel-novatek-nt39016.c
drivers/gpu/drm/panel/panel-olimex-lcd-olinuxino.c
drivers/gpu/drm/panel/panel-osd-osd101t2587-53ts.c
drivers/gpu/drm/panel/panel-panasonic-vvx10f034n00.c
drivers/gpu/drm/panel/panel-raspberrypi-touchscreen.c
drivers/gpu/drm/panel/panel-raydium-rm67191.c
drivers/gpu/drm/panel/panel-ronbo-rb070d30.c
drivers/gpu/drm/panel/panel-samsung-ld9040.c
drivers/gpu/drm/panel/panel-samsung-s6d16d0.c
drivers/gpu/drm/panel/panel-samsung-s6e3ha2.c
drivers/gpu/drm/panel/panel-samsung-s6e63j0x03.c
drivers/gpu/drm/panel/panel-samsung-s6e63m0.c
drivers/gpu/drm/panel/panel-samsung-s6e88a0-ams452ef01.c
drivers/gpu/drm/panel/panel-samsung-s6e8aa0.c
drivers/gpu/drm/panel/panel-seiko-43wvf1g.c
drivers/gpu/drm/panel/panel-sharp-lq101r1sx01.c
drivers/gpu/drm/panel/panel-sharp-ls037v7dw01.c
drivers/gpu/drm/panel/panel-sharp-ls043t1le01.c
drivers/gpu/drm/panel/panel-simple.c
drivers/gpu/drm/panel/panel-sitronix-st7701.c
drivers/gpu/drm/panel/panel-sitronix-st7789v.c
drivers/gpu/drm/panel/panel-sony-acx424akp.c
drivers/gpu/drm/panel/panel-sony-acx565akm.c
drivers/gpu/drm/panel/panel-tpo-td028ttec1.c
drivers/gpu/drm/panel/panel-tpo-td043mtea1.c
drivers/gpu/drm/panel/panel-tpo-tpg110.c
include/drm/drm_panel.h

index 8c7bac85a793779bf93476a33b7423142e42c1ad..b8e9abb537cfc0f62ed0b6a3c2c485e0eb8d108a 100644 (file)
@@ -70,16 +70,12 @@ EXPORT_SYMBOL(drm_panel_init);
  *
  * Add a panel to the global registry so that it can be looked up by display
  * drivers.
- *
- * Return: 0 on success or a negative error code on failure.
  */
-int drm_panel_add(struct drm_panel *panel)
+void drm_panel_add(struct drm_panel *panel)
 {
        mutex_lock(&panel_lock);
        list_add_tail(&panel->list, &panel_list);
        mutex_unlock(&panel_lock);
-
-       return 0;
 }
 EXPORT_SYMBOL(drm_panel_add);
 
index 47b37fef7ee8abeb0382fad6ee39bfa32d01eec5..abb0788843c60c77664e2c9fac6ba324a9ebae23 100644 (file)
@@ -349,7 +349,9 @@ static int versatile_panel_probe(struct platform_device *pdev)
        drm_panel_init(&vpanel->panel, dev, &versatile_panel_drm_funcs,
                       DRM_MODE_CONNECTOR_DPI);
 
-       return drm_panel_add(&vpanel->panel);
+       drm_panel_add(&vpanel->panel);
+
+       return 0;
 }
 
 static const struct of_device_id versatile_panel_match[] = {
index 9a5b7644d756e7bd3a73962a1c3d08c67bca340c..e95bc9f60b3fb95caf2d9d4cda9a0b1cd61ec6e9 100644 (file)
@@ -315,11 +315,7 @@ static int tm5p5_nt35596_probe(struct mipi_dsi_device *dsi)
                return ret;
        }
 
-       ret = drm_panel_add(&ctx->panel);
-       if (ret < 0) {
-               dev_err(dev, "Failed to add panel: %d\n", ret);
-               return ret;
-       }
+       drm_panel_add(&ctx->panel);
 
        ret = mipi_dsi_attach(dsi);
        if (ret < 0) {
index 7c27bd5e34860ba726aaf6210c64540705833377..d676b4c2a8fa4bc35e734cde3368e24e3cfe4ffe 100644 (file)
@@ -895,7 +895,9 @@ static int panel_add(struct panel_info *pinfo)
        if (ret)
                return ret;
 
-       return drm_panel_add(&pinfo->base);
+       drm_panel_add(&pinfo->base);
+
+       return 0;
 }
 
 static int panel_probe(struct mipi_dsi_device *dsi)
index db5b866357f28d902ff68edc1cebaf904656b460..3bd46600a98ba31f0a057e8e572601b9d00a33d7 100644 (file)
@@ -787,7 +787,9 @@ static int boe_panel_add(struct boe_panel *boe)
        boe->base.funcs = &boe_panel_funcs;
        boe->base.dev = &boe->dsi->dev;
 
-       return drm_panel_add(&boe->base);
+       drm_panel_add(&boe->base);
+
+       return 0;
 }
 
 static int boe_panel_probe(struct mipi_dsi_device *dsi)
index 54610651ecdb30a95fe50d927f911aa95c7134e9..0b7e82e5ba4e3a6b7c739b38029530ea5225fe7c 100644 (file)
@@ -477,9 +477,7 @@ static int k101_im2ba02_dsi_probe(struct mipi_dsi_device *dsi)
        if (ret)
                return ret;
 
-       ret = drm_panel_add(&ctx->panel);
-       if (ret < 0)
-               return ret;
+       drm_panel_add(&ctx->panel);
 
        dsi->mode_flags = MIPI_DSI_MODE_VIDEO;
        dsi->format = MIPI_DSI_FMT_RGB888;
index 19a6274b10f505c4535135a7cb189aaf70612e78..f9edee69fea406f2091fa5a1e6c37195ce7946ea 100644 (file)
@@ -224,9 +224,7 @@ static int feiyang_dsi_probe(struct mipi_dsi_device *dsi)
        if (ret)
                return ret;
 
-       ret = drm_panel_add(&ctx->panel);
-       if (ret < 0)
-               return ret;
+       drm_panel_add(&ctx->panel);
 
        dsi->mode_flags = MIPI_DSI_MODE_VIDEO_BURST;
        dsi->format = MIPI_DSI_FMT_RGB888;
index 67a64d1999f69c4ab02f53afd2e2a2c5c822e211..968845894725704797c1f144b7bc2b6c935824ae 100644 (file)
@@ -892,7 +892,9 @@ static int ili9322_probe(struct spi_device *spi)
        drm_panel_init(&ili->panel, dev, &ili9322_drm_funcs,
                       DRM_MODE_CONNECTOR_DPI);
 
-       return drm_panel_add(&ili->panel);
+       drm_panel_add(&ili->panel);
+
+       return 0;
 }
 
 static int ili9322_remove(struct spi_device *spi)
index 3ed8635a6fbdf7fd75c1df60f864b14e15c28838..066ef6c535df0dd5f00ea03a84f0338f3ddea67b 100644 (file)
@@ -446,9 +446,7 @@ static int ili9881c_dsi_probe(struct mipi_dsi_device *dsi)
        if (ret)
                return ret;
 
-       ret = drm_panel_add(&ctx->panel);
-       if (ret < 0)
-               return ret;
+       drm_panel_add(&ctx->panel);
 
        dsi->mode_flags = MIPI_DSI_MODE_VIDEO_SYNC_PULSE;
        dsi->format = MIPI_DSI_FMT_RGB888;
index fdf030f4cf92d7bc3bd37b299f494b9a25e76557..1a8e69c641253b8f06a9dcf4fb56988df021200b 100644 (file)
@@ -475,9 +475,7 @@ static int innolux_panel_add(struct mipi_dsi_device *dsi,
        if (err)
                return err;
 
-       err = drm_panel_add(&innolux->base);
-       if (err < 0)
-               return err;
+       drm_panel_add(&innolux->base);
 
        mipi_dsi_set_drvdata(dsi, innolux);
        innolux->link = dsi;
index 1e3fd6633981f35c6b372de900a8e3fb9c78c694..733010b5e4f536316a59e7200793b620224613de 100644 (file)
@@ -440,9 +440,9 @@ static int jdi_panel_add(struct jdi_panel *jdi)
        drm_panel_init(&jdi->base, &jdi->dsi->dev, &jdi_panel_funcs,
                       DRM_MODE_CONNECTOR_DSI);
 
-       ret = drm_panel_add(&jdi->base);
+       drm_panel_add(&jdi->base);
 
-       return ret;
+       return 0;
 }
 
 static void jdi_panel_del(struct jdi_panel *jdi)
index 0d397af23afe7e6b03d8720cd89e73c428f8870a..f42dc2ceeb079fce40caa038d1424fedf172a441 100644 (file)
@@ -382,7 +382,9 @@ static int kingdisplay_panel_add(struct kingdisplay_panel *kingdisplay)
        if (err)
                return err;
 
-       return drm_panel_add(&kingdisplay->base);
+       drm_panel_add(&kingdisplay->base);
+
+       return 0;
 }
 
 static void kingdisplay_panel_del(struct kingdisplay_panel *kingdisplay)
index 14456b9cd5c013f9317a8091073a588f60c1c5db..f3183b68704f6e0911499c257e00c71c7e06adb2 100644 (file)
@@ -198,7 +198,9 @@ static int lb035q02_probe(struct spi_device *spi)
        drm_panel_init(&lcd->panel, &lcd->spi->dev, &lb035q02_funcs,
                       DRM_MODE_CONNECTOR_DPI);
 
-       return drm_panel_add(&lcd->panel);
+       drm_panel_add(&lcd->panel);
+
+       return 0;
 }
 
 static int lb035q02_remove(struct spi_device *spi)
index aedc485d0727355d0f64c0c3fa405d2855af83f1..8e5160af1de5dd177b19c1083969ec8e969257f9 100644 (file)
@@ -261,7 +261,9 @@ static int lg4573_probe(struct spi_device *spi)
        drm_panel_init(&ctx->panel, &spi->dev, &lg4573_drm_funcs,
                       DRM_MODE_CONNECTOR_DPI);
 
-       return drm_panel_add(&ctx->panel);
+       drm_panel_add(&ctx->panel);
+
+       return 0;
 }
 
 static int lg4573_remove(struct spi_device *spi)
index 5ce3f4a2b7a19da6849b41fdb697c8d71025a3db..41305c3dcf31801f34c66b2d0547e593443aacef 100644 (file)
@@ -227,9 +227,7 @@ static int panel_lvds_probe(struct platform_device *pdev)
        if (ret)
                return ret;
 
-       ret = drm_panel_add(&lvds->panel);
-       if (ret < 0)
-               return ret;
+       drm_panel_add(&lvds->panel);
 
        dev_set_drvdata(lvds->dev, lvds);
        return 0;
index f894971c1c7c5f4d2c4bd903c15caab1e544f6cf..6e5ab1debc8b43534d77be6251d70cea8d576a53 100644 (file)
@@ -207,7 +207,9 @@ static int nl8048_probe(struct spi_device *spi)
        drm_panel_init(&lcd->panel, &lcd->spi->dev, &nl8048_funcs,
                       DRM_MODE_CONNECTOR_DPI);
 
-       return drm_panel_add(&lcd->panel);
+       drm_panel_add(&lcd->panel);
+
+       return 0;
 }
 
 static int nl8048_remove(struct spi_device *spi)
index e98d54df00e7bd1f208c8c01c3502a7375ac8092..e67d0955e215256bdb3eaf1fef48dee69b725203 100644 (file)
@@ -956,9 +956,7 @@ static int nt35510_probe(struct mipi_dsi_device *dsi)
                nt->panel.backlight = bl;
        }
 
-       ret = drm_panel_add(&nt->panel);
-       if (ret < 0)
-               return ret;
+       drm_panel_add(&nt->panel);
 
        ret = mipi_dsi_attach(dsi);
        if (ret < 0)
index 91df050ba3f638cc2d4cbbea754ed2a9171704ff..3d15d9925204431c05573ceac51020a6604501ee 100644 (file)
@@ -303,11 +303,7 @@ static int nt39016_probe(struct spi_device *spi)
        drm_panel_init(&panel->drm_panel, dev, &nt39016_funcs,
                       DRM_MODE_CONNECTOR_DPI);
 
-       err = drm_panel_add(&panel->drm_panel);
-       if (err < 0) {
-               dev_err(dev, "Failed to register panel");
-               return err;
-       }
+       drm_panel_add(&panel->drm_panel);
 
        return 0;
 }
index ecd76b5391d318f6a612115d0a9d2bc4e8cfce8f..cb5cb27462df16f9467522dc86d96cb3e1dbf047 100644 (file)
@@ -283,7 +283,9 @@ static int lcd_olinuxino_probe(struct i2c_client *client,
        if (ret)
                return ret;
 
-       return drm_panel_add(&lcd->panel);
+       drm_panel_add(&lcd->panel);
+
+       return 0;
 }
 
 static int lcd_olinuxino_remove(struct i2c_client *client)
index 83e5aa47f0d673b1a6071357f305493823c63baf..45b975dee587bb280c7d7304db0afe1b1c530cbe 100644 (file)
@@ -164,7 +164,9 @@ static int osd101t2587_panel_add(struct osd101t2587_panel *osd101t2587)
        if (ret)
                return ret;
 
-       return drm_panel_add(&osd101t2587->base);
+       drm_panel_add(&osd101t2587->base);
+
+       return 0;
 }
 
 static int osd101t2587_panel_probe(struct mipi_dsi_device *dsi)
index 627dfcf8adb4db6f8c8dc8065d29356f3c91673d..3c20beeb17819dc024e9ab3ca1239acfe102ba17 100644 (file)
@@ -206,7 +206,9 @@ static int wuxga_nt_panel_add(struct wuxga_nt_panel *wuxga_nt)
        if (ret)
                return ret;
 
-       return drm_panel_add(&wuxga_nt->base);
+       drm_panel_add(&wuxga_nt->base);
+
+       return 0;
 }
 
 static void wuxga_nt_panel_del(struct wuxga_nt_panel *wuxga_nt)
index e50ee26474cfef4cd276eb5446a68321a178ca9e..5e9ccefb88f62472c2db2815d2174ebe6bd6c7ee 100644 (file)
@@ -361,7 +361,7 @@ static int rpi_touchscreen_probe(struct i2c_client *i2c,
        struct rpi_touchscreen *ts;
        struct device_node *endpoint, *dsi_host_node;
        struct mipi_dsi_host *host;
-       int ret, ver;
+       int ver;
        struct mipi_dsi_device_info info = {
                .type = RPI_DSI_DRIVER_NAME,
                .channel = 0,
@@ -429,9 +429,7 @@ static int rpi_touchscreen_probe(struct i2c_client *i2c,
        /* This appears last, as it's what will unblock the DSI host
         * driver's component bind function.
         */
-       ret = drm_panel_add(&ts->base);
-       if (ret)
-               return ret;
+       drm_panel_add(&ts->base);
 
        return 0;
 
index 57ff2b1f636175388dcb4d9e06c470a88137d857..2ef32258213399ddfe6b3f858db01f7ea380fb02 100644 (file)
@@ -609,9 +609,7 @@ static int rad_panel_probe(struct mipi_dsi_device *dsi)
                       DRM_MODE_CONNECTOR_DSI);
        dev_set_drvdata(dev, panel);
 
-       ret = drm_panel_add(&panel->panel);
-       if (ret)
-               return ret;
+       drm_panel_add(&panel->panel);
 
        ret = mipi_dsi_attach(dsi);
        if (ret)
index a7b0b3e39e1a5a0c3ad9be8b76ee14d6705d7394..ea74958d7544d018498692ea2da5a723ad1ab6c8 100644 (file)
@@ -200,9 +200,7 @@ static int rb070d30_panel_dsi_probe(struct mipi_dsi_device *dsi)
        if (ret)
                return ret;
 
-       ret = drm_panel_add(&ctx->panel);
-       if (ret < 0)
-               return ret;
+       drm_panel_add(&ctx->panel);
 
        dsi->mode_flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_BURST | MIPI_DSI_MODE_LPM;
        dsi->format = MIPI_DSI_FMT_RGB888;
index 9bb2e8c7934ab9c4c45262465ec0e153f7ff93c8..358168ed8355dcf93a2d596c7fe53df7a91f9c69 100644 (file)
@@ -354,7 +354,9 @@ static int ld9040_probe(struct spi_device *spi)
        drm_panel_init(&ctx->panel, dev, &ld9040_drm_funcs,
                       DRM_MODE_CONNECTOR_DPI);
 
-       return drm_panel_add(&ctx->panel);
+       drm_panel_add(&ctx->panel);
+
+       return 0;
 }
 
 static int ld9040_remove(struct spi_device *spi)
index f02645d396aca44118ff9b17ce6b683f658805b1..e88af6f8bf60d9ef107bcfa1f75db9151f1161c2 100644 (file)
@@ -212,9 +212,7 @@ static int s6d16d0_probe(struct mipi_dsi_device *dsi)
        drm_panel_init(&s6->panel, dev, &s6d16d0_drm_funcs,
                       DRM_MODE_CONNECTOR_DSI);
 
-       ret = drm_panel_add(&s6->panel);
-       if (ret < 0)
-               return ret;
+       drm_panel_add(&s6->panel);
 
        ret = mipi_dsi_attach(dsi);
        if (ret < 0)
index 80ef122e7466dd3f9777682d16495156ff4d32db..2c84036c6a65e56a741d91bc7efd7aad7e32a2c3 100644 (file)
@@ -733,9 +733,7 @@ static int s6e3ha2_probe(struct mipi_dsi_device *dsi)
        drm_panel_init(&ctx->panel, dev, &s6e3ha2_drm_funcs,
                       DRM_MODE_CONNECTOR_DSI);
 
-       ret = drm_panel_add(&ctx->panel);
-       if (ret < 0)
-               goto unregister_backlight;
+       drm_panel_add(&ctx->panel);
 
        ret = mipi_dsi_attach(dsi);
        if (ret < 0)
@@ -745,8 +743,6 @@ static int s6e3ha2_probe(struct mipi_dsi_device *dsi)
 
 remove_panel:
        drm_panel_remove(&ctx->panel);
-
-unregister_backlight:
        backlight_device_unregister(ctx->bl_dev);
 
        return ret;
index 1247656d73bf1ce166edbead62997031164aed5a..7a43eb3545cfbfeb69b5d17b601cc3385a1c82c2 100644 (file)
@@ -479,9 +479,7 @@ static int s6e63j0x03_probe(struct mipi_dsi_device *dsi)
        ctx->bl_dev->props.brightness = DEFAULT_BRIGHTNESS;
        ctx->bl_dev->props.power = FB_BLANK_POWERDOWN;
 
-       ret = drm_panel_add(&ctx->panel);
-       if (ret < 0)
-               goto unregister_backlight;
+       drm_panel_add(&ctx->panel);
 
        ret = mipi_dsi_attach(dsi);
        if (ret < 0)
@@ -491,8 +489,6 @@ static int s6e63j0x03_probe(struct mipi_dsi_device *dsi)
 
 remove_panel:
        drm_panel_remove(&ctx->panel);
-
-unregister_backlight:
        backlight_device_unregister(ctx->bl_dev);
 
        return ret;
index 64421347bfd473a406f7cc79305d3996380f84c9..e086efea295050ecce73b5fb3838830f18f4b7bf 100644 (file)
@@ -479,7 +479,9 @@ static int s6e63m0_probe(struct spi_device *spi)
        if (ret < 0)
                return ret;
 
-       return drm_panel_add(&ctx->panel);
+       drm_panel_add(&ctx->panel);
+
+       return 0;
 }
 
 static int s6e63m0_remove(struct spi_device *spi)
index 485eabecfcc952dc6695193cef60a17881d822ef..ea63799ff2a1e427fc872282e97f573e5e97ec5d 100644 (file)
@@ -242,11 +242,7 @@ static int s6e88a0_ams452ef01_probe(struct mipi_dsi_device *dsi)
        drm_panel_init(&ctx->panel, dev, &s6e88a0_ams452ef01_panel_funcs,
                       DRM_MODE_CONNECTOR_DSI);
 
-       ret = drm_panel_add(&ctx->panel);
-       if (ret < 0) {
-               dev_err(dev, "Failed to add panel: %d\n", ret);
-               return ret;
-       }
+       drm_panel_add(&ctx->panel);
 
        ret = mipi_dsi_attach(dsi);
        if (ret < 0) {
index 8a028d2bd0d6008a70fcad806752c25dddd1adae..e36cb1a253187c4a65878f11b24f4b7574ada312 100644 (file)
@@ -1020,9 +1020,7 @@ static int s6e8aa0_probe(struct mipi_dsi_device *dsi)
        drm_panel_init(&ctx->panel, dev, &s6e8aa0_drm_funcs,
                       DRM_MODE_CONNECTOR_DSI);
 
-       ret = drm_panel_add(&ctx->panel);
-       if (ret < 0)
-               return ret;
+       drm_panel_add(&ctx->panel);
 
        ret = mipi_dsi_attach(dsi);
        if (ret < 0)
index e417dc4921c2c8f5d2319e6ad9700c8a5143ad6b..0ee508576231fdb3f8c6c47941b074a5572e8d64 100644 (file)
@@ -258,9 +258,7 @@ static int seiko_panel_probe(struct device *dev,
        if (err)
                return err;
 
-       err = drm_panel_add(&panel->base);
-       if (err < 0)
-               return err;
+       drm_panel_add(&panel->base);
 
        dev_set_drvdata(dev, panel);
 
index f07324b705b357d22d67e7a2990f4834dbe4f113..f8cd2a42ed13bd25fd653deebb5416d865db1702 100644 (file)
@@ -325,7 +325,9 @@ static int sharp_panel_add(struct sharp_panel *sharp)
        if (ret)
                return ret;
 
-       return drm_panel_add(&sharp->base);
+       drm_panel_add(&sharp->base);
+
+       return 0;
 }
 
 static void sharp_panel_del(struct sharp_panel *sharp)
index d7bf13b9e1d62847a2bb3e33f4158ffca7f77bf5..94992f45113a946fe8a942515db0e2d2faacab53 100644 (file)
@@ -187,7 +187,9 @@ static int ls037v7dw01_probe(struct platform_device *pdev)
        drm_panel_init(&lcd->panel, &pdev->dev, &ls037v7dw01_funcs,
                       DRM_MODE_CONNECTOR_DPI);
 
-       return drm_panel_add(&lcd->panel);
+       drm_panel_add(&lcd->panel);
+
+       return 0;
 }
 
 static int ls037v7dw01_remove(struct platform_device *pdev)
index b2e58935529cb7147a8eb3571b4d705a054cee2d..16dbf0f353edaf3b4f946028157c95291b3d615e 100644 (file)
@@ -261,7 +261,9 @@ static int sharp_nt_panel_add(struct sharp_nt_panel *sharp_nt)
        if (ret)
                return ret;
 
-       return drm_panel_add(&sharp_nt->base);
+       drm_panel_add(&sharp_nt->base);
+
+       return 0;
 }
 
 static void sharp_nt_panel_del(struct sharp_nt_panel *sharp_nt)
index 221859652d82b0cac7d99251cd18bffb9643c4de..67ca543e74e8ca4e5aa0f239233ee83fbdc13924 100644 (file)
@@ -613,9 +613,7 @@ static int panel_simple_probe(struct device *dev, const struct panel_desc *desc)
        if (err)
                goto free_ddc;
 
-       err = drm_panel_add(&panel->base);
-       if (err < 0)
-               goto free_ddc;
+       drm_panel_add(&panel->base);
 
        dev_set_drvdata(dev, panel);
 
index 692041ae4eb652e89de8e4e28c0f000733b80447..12462114a52d82f47ef0c712ea14cb58f839f4ba 100644 (file)
@@ -380,9 +380,7 @@ static int st7701_dsi_probe(struct mipi_dsi_device *dsi)
        if (ret)
                return ret;
 
-       ret = drm_panel_add(&st7701->panel);
-       if (ret < 0)
-               return ret;
+       drm_panel_add(&st7701->panel);
 
        mipi_dsi_set_drvdata(dsi, st7701);
        st7701->dsi = dsi;
index 3513ae40efa8cd637a70a0de329aaeed76e2503d..61e565524542c7e284726a5c34f770180e9084f4 100644 (file)
@@ -382,9 +382,7 @@ static int st7789v_probe(struct spi_device *spi)
        if (ret)
                return ret;
 
-       ret = drm_panel_add(&ctx->panel);
-       if (ret < 0)
-               return ret;
+       drm_panel_add(&ctx->panel);
 
        return 0;
 }
index 97a1b4790d3c2c2d738df2cb88e8c9a7e1053026..57575c40f2aa629dfe6b1168080101bb451b4629 100644 (file)
@@ -504,9 +504,7 @@ static int acx424akp_probe(struct mipi_dsi_device *dsi)
        acx->bl->props.brightness = 512;
        acx->bl->props.power = FB_BLANK_POWERDOWN;
 
-       ret = drm_panel_add(&acx->panel);
-       if (ret < 0)
-               return ret;
+       drm_panel_add(&acx->panel);
 
        ret = mipi_dsi_attach(dsi);
        if (ret < 0) {
index fc6a7e451abef91df1a980a6e159fc1e81a270c9..e95fdfb16b6c9cc4dcc0c0a38a10eec5834c6a94 100644 (file)
@@ -650,12 +650,7 @@ static int acx565akm_probe(struct spi_device *spi)
        drm_panel_init(&lcd->panel, &lcd->spi->dev, &acx565akm_funcs,
                       DRM_MODE_CONNECTOR_DPI);
 
-       ret = drm_panel_add(&lcd->panel);
-       if (ret < 0) {
-               if (lcd->has_bc)
-                       acx565akm_backlight_cleanup(lcd);
-               return ret;
-       }
+       drm_panel_add(&lcd->panel);
 
        return 0;
 }
index 58d683cc52154781e50dc037f93f5e8ff6413818..037c14fd6bacf3efdf60f4e8025aed69eb80bf29 100644 (file)
@@ -350,7 +350,9 @@ static int td028ttec1_probe(struct spi_device *spi)
        if (ret)
                return ret;
 
-       return drm_panel_add(&lcd->panel);
+       drm_panel_add(&lcd->panel);
+
+       return 0;
 }
 
 static int td028ttec1_remove(struct spi_device *spi)
index 9b2a356c4d9a962501079b670808611266de072f..49e6c93862587c301ac1f2988f87c7947bbc4db8 100644 (file)
@@ -460,11 +460,7 @@ static int td043mtea1_probe(struct spi_device *spi)
        drm_panel_init(&lcd->panel, &lcd->spi->dev, &td043mtea1_funcs,
                       DRM_MODE_CONNECTOR_DPI);
 
-       ret = drm_panel_add(&lcd->panel);
-       if (ret < 0) {
-               sysfs_remove_group(&spi->dev.kobj, &td043mtea1_attr_group);
-               return ret;
-       }
+       drm_panel_add(&lcd->panel);
 
        return 0;
 }
index c7a2f0ae5ba51863dfb8290ff1c24be77f436c00..cd00cfa6ba1496766d76e97cc42ffb3bfe857865 100644 (file)
@@ -448,7 +448,9 @@ static int tpg110_probe(struct spi_device *spi)
 
        spi_set_drvdata(spi, tpg);
 
-       return drm_panel_add(&tpg->panel);
+       drm_panel_add(&tpg->panel);
+
+       return 0;
 }
 
 static int tpg110_remove(struct spi_device *spi)
index 6193cb555accc2f6bfa22152c26523dc636f4c0c..ff066524cb70791b105569e7a1ca9a1e80e3e98f 100644 (file)
@@ -175,7 +175,7 @@ void drm_panel_init(struct drm_panel *panel, struct device *dev,
                    const struct drm_panel_funcs *funcs,
                    int connector_type);
 
-int drm_panel_add(struct drm_panel *panel);
+void drm_panel_add(struct drm_panel *panel);
 void drm_panel_remove(struct drm_panel *panel);
 
 int drm_panel_attach(struct drm_panel *panel, struct drm_connector *connector);