drm/amd: Don't init MEC2 firmware when it fails to load
authorDavid McFarland <corngood@gmail.com>
Mon, 29 Jan 2024 22:18:22 +0000 (18:18 -0400)
committerAlex Deucher <alexander.deucher@amd.com>
Wed, 31 Jan 2024 18:53:06 +0000 (13:53 -0500)
The same calls are made directly above, but conditional on the firmware
loading and validating successfully.

Cc: stable@vger.kernel.org
Fixes: 9931b67690cf ("drm/amd: Load GFX10 microcode during early_init")
Signed-off-by: David McFarland <corngood@gmail.com>
Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c

index be4d5c1e826f3efd8628151b06d9e5f1e45105a3..b02d63328f1cd937063cc031f553c4c44e2d4e9c 100644 (file)
@@ -4027,8 +4027,6 @@ static int gfx_v10_0_init_microcode(struct amdgpu_device *adev)
                err = 0;
                adev->gfx.mec2_fw = NULL;
        }
-       amdgpu_gfx_cp_init_microcode(adev, AMDGPU_UCODE_ID_CP_MEC2);
-       amdgpu_gfx_cp_init_microcode(adev, AMDGPU_UCODE_ID_CP_MEC2_JT);
 
        gfx_v10_0_check_fw_write_wait(adev);
 out: