ARM: OMAP2+: add missing call to of_node_put()
authorYang Li <yang.lee@linux.alibaba.com>
Thu, 25 Feb 2021 08:54:50 +0000 (16:54 +0800)
committerTony Lindgren <tony@atomide.com>
Wed, 24 Mar 2021 11:32:57 +0000 (13:32 +0200)
In one of the error paths of the for_each_child_of_node() loop,
add missing call to of_node_put().

Fix the following coccicheck warning:
./arch/arm/mach-omap2/omap_hwmod.c:2132:1-23: WARNING: Function
"for_each_child_of_node" should have of_node_put() before return around
line 2140.

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
Signed-off-by: Tony Lindgren <tony@atomide.com>
arch/arm/mach-omap2/omap_hwmod.c

index 2310cd56e99b55247b2d9ec2d491a4d411a5d355..007e91ed6aa4c0b4e2320bd75a4636de3ad8a275 100644 (file)
@@ -2137,6 +2137,7 @@ static int of_dev_hwmod_lookup(struct device_node *np,
                if (res == 0) {
                        *found = fc;
                        *index = i;
+                       of_node_put(np0);
                        return 0;
                }
        }