HID: cp2112: make sysfs attributes static
authorJiri Kosina <jkosina@suse.cz>
Mon, 17 Feb 2014 22:40:20 +0000 (23:40 +0100)
committerJiri Kosina <jkosina@suse.cz>
Mon, 17 Feb 2014 22:40:20 +0000 (23:40 +0100)
No need to pollute namespace with dev_attr_*.

Signed-off-by: Jiri Kosina <jkosina@suse.cz>
drivers/hid/hid-cp2112.c

index ca0f356a2384884bd3cffd4889f30a4c4784ef6b..57cf04555a03463a51723108925364c2090e22c8 100644 (file)
@@ -663,7 +663,7 @@ static ssize_t name##_show(struct device *kdev, \
                return ret; \
        return scnprintf(buf, PAGE_SIZE, format, ##__VA_ARGS__); \
 } \
-DEVICE_ATTR_RW(name);
+static DEVICE_ATTR_RW(name);
 
 CP2112_CONFIG_ATTR(vendor_id, ({
        u16 vid;
@@ -784,7 +784,7 @@ static ssize_t pstr_show(struct device *kdev,
 }
 
 #define CP2112_PSTR_ATTR(name, _report) \
-struct cp2112_pstring_attribute dev_attr_##name = { \
+static struct cp2112_pstring_attribute dev_attr_##name = { \
        .attr = __ATTR(name, (S_IWUSR | S_IRUGO), pstr_show, pstr_store), \
        .report = _report, \
 };