drm/mediatek: mtk_hdmi: Fix inverted parameters in some regmap_update_bits calls
authorLouis-Alexis Eyraud <louisalexis.eyraud@collabora.com>
Mon, 18 Aug 2025 14:17:52 +0000 (16:17 +0200)
committerChun-Kuang Hu <chunkuang.hu@kernel.org>
Thu, 28 Aug 2025 23:15:41 +0000 (23:15 +0000)
In mtk_hdmi driver, a recent change replaced custom register access
function calls by regmap ones, but two replacements by regmap_update_bits
were done incorrectly, because original offset and mask parameters were
inverted, so fix them.

Fixes: d6e25b3590a0 ("drm/mediatek: hdmi: Use regmap instead of iomem for main registers")
Signed-off-by: Louis-Alexis Eyraud <louisalexis.eyraud@collabora.com>
Reviewed-by: CK Hu <ck.hu@mediatek.com>
Link: https://patchwork.kernel.org/project/dri-devel/patch/20250818-mt8173-fix-hdmi-issue-v1-1-55aff9b0295d@collabora.com/
Signed-off-by: Chun-Kuang Hu <chunkuang.hu@kernel.org>
drivers/gpu/drm/mediatek/mtk_hdmi.c

index 845fd8aa43c3c91659808d9e6bb78758d1f9b857..b766dd5e6c8de6d16bff50972b45c3c1a083b985 100644 (file)
@@ -182,8 +182,8 @@ static inline struct mtk_hdmi *hdmi_ctx_from_bridge(struct drm_bridge *b)
 
 static void mtk_hdmi_hw_vid_black(struct mtk_hdmi *hdmi, bool black)
 {
-       regmap_update_bits(hdmi->regs, VIDEO_SOURCE_SEL,
-                          VIDEO_CFG_4, black ? GEN_RGB : NORMAL_PATH);
+       regmap_update_bits(hdmi->regs, VIDEO_CFG_4,
+                          VIDEO_SOURCE_SEL, black ? GEN_RGB : NORMAL_PATH);
 }
 
 static void mtk_hdmi_hw_make_reg_writable(struct mtk_hdmi *hdmi, bool enable)
@@ -310,8 +310,8 @@ static void mtk_hdmi_hw_send_info_frame(struct mtk_hdmi *hdmi, u8 *buffer,
 
 static void mtk_hdmi_hw_send_aud_packet(struct mtk_hdmi *hdmi, bool enable)
 {
-       regmap_update_bits(hdmi->regs, AUDIO_PACKET_OFF,
-                          GRL_SHIFT_R2, enable ? 0 : AUDIO_PACKET_OFF);
+       regmap_update_bits(hdmi->regs, GRL_SHIFT_R2,
+                          AUDIO_PACKET_OFF, enable ? 0 : AUDIO_PACKET_OFF);
 }
 
 static void mtk_hdmi_hw_config_sys(struct mtk_hdmi *hdmi)