mm/damon/core: unset damos->walk_completed after confimed set
authorSeongJae Park <sj@kernel.org>
Mon, 10 Feb 2025 18:27:34 +0000 (10:27 -0800)
committerAndrew Morton <akpm@linux-foundation.org>
Mon, 17 Mar 2025 05:06:09 +0000 (22:06 -0700)
Patch series "mm/damon/core: fix wrong and/or useless damos_walk()
behaviors".

damos_walk() can finish working earlier or later than expected, and start
earlier than practical.  First two behaviors are clearly wrong behavior
(doesn't follow the documentation) and all three behaviors are only making
the feature useless.  Fix those.

This patch (of 3):

damos->walk_completed is only set, not unset.  This can cause next
damos_walk() finish earlier than expected.  Unset it after all
walk_completed is confirmed.

Link: https://lkml.kernel.org/r/20250210182737.134994-1-sj@kernel.org
Link: https://lkml.kernel.org/r/20250210182737.134994-2-sj@kernel.org
Fixes: bf0eaba0ff9c ("mm/damon/core: implement damos_walk()")
Signed-off-by: SeongJae Park <sj@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
mm/damon/core.c

index dc8f94fe7c3bc816f796f5f3d06108caf8e6c84b..8e4ae9901b197a513d205d8992c28c30c7b683d1 100644 (file)
@@ -1494,6 +1494,9 @@ static void damos_walk_complete(struct damon_ctx *ctx, struct damos *s)
                if (!siter->walk_completed)
                        return;
        }
+       damon_for_each_scheme(siter, ctx)
+               siter->walk_completed = false;
+
        complete(&control->completion);
        mutex_lock(&ctx->walk_control_lock);
        ctx->walk_control = NULL;