nvme-pci: add missing condition check for existence of mapped data
authorLeon Romanovsky <leonro@nvidia.com>
Wed, 24 Jul 2024 10:31:14 +0000 (13:31 +0300)
committerKeith Busch <kbusch@kernel.org>
Thu, 25 Jul 2024 14:20:54 +0000 (07:20 -0700)
nvme_map_data() is called when request has physical segments, hence
the nvme_unmap_data() should have same condition to avoid dereference.

Fixes: 4aedb705437f ("nvme-pci: split metadata handling from nvme_map_data / nvme_unmap_data")
Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Nitesh Shetty <nj.shetty@samsung.com>
Signed-off-by: Keith Busch <kbusch@kernel.org>
drivers/nvme/host/pci.c

index 8087b054da668cab6f647862786152b330618cef..6cd9395ba9ec3d8044b4eaf0e6665c7d739d718d 100644 (file)
@@ -863,7 +863,8 @@ static blk_status_t nvme_prep_rq(struct nvme_dev *dev, struct request *req)
        nvme_start_request(req);
        return BLK_STS_OK;
 out_unmap_data:
-       nvme_unmap_data(dev, req);
+       if (blk_rq_nr_phys_segments(req))
+               nvme_unmap_data(dev, req);
 out_free_cmd:
        nvme_cleanup_cmd(req);
        return ret;