block: Drop locking annotation for limits_lock
authorJohn Garry <john.g.garry@oracle.com>
Fri, 14 Jun 2024 09:03:44 +0000 (09:03 +0000)
committerJens Axboe <axboe@kernel.dk>
Sun, 16 Jun 2024 21:30:26 +0000 (15:30 -0600)
Currently compiling block/blk-settings.c with C=1 gives the following
warning:
block/blk-settings.c:262:9: warning: context imbalance in 'queue_limits_commit_update' - wrong count at exit

request_queue.limits_lock is a mutex. Sparse locking annotation for
mutexes are currently not supported - see [0] - so drop that locking
annotation.

[0] https://lore.kernel.org/lkml/cover.1579893447.git.jbi.octave@gmail.com/T/#mbb8bda6c0a7ca7ce19f46df976a8e3b489745488

Fixes: d690cb8ae14bd ("block: add an API to atomically update queue limits")
Signed-off-by: John Garry <john.g.garry@oracle.com>
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Link: https://lore.kernel.org/r/20240614090345.655716-3-john.g.garry@oracle.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
block/blk-settings.c
include/linux/blkdev.h

index f574181105f8a5de63b55c0570d7529a9e17b26c..377a86fe0fcc411f7e42343d13c561d6bf6cd038 100644 (file)
@@ -303,7 +303,6 @@ int blk_set_default_limits(struct queue_limits *lim)
  */
 int queue_limits_commit_update(struct request_queue *q,
                struct queue_limits *lim)
-       __releases(q->limits_lock)
 {
        int error;
 
index 0c247a71688561cd18f201343f32794473341832..83af6ac5aa4819bb3efcb568638a581882dc116d 100644 (file)
@@ -893,7 +893,6 @@ static inline unsigned int blk_chunk_sectors_left(sector_t offset,
  */
 static inline struct queue_limits
 queue_limits_start_update(struct request_queue *q)
-       __acquires(q->limits_lock)
 {
        mutex_lock(&q->limits_lock);
        return q->limits;