selftests/xsk: Make sure single threaded test terminates
authorMaciej Fijalkowski <maciej.fijalkowski@intel.com>
Thu, 1 Sep 2022 11:48:12 +0000 (13:48 +0200)
committerDaniel Borkmann <daniel@iogearbox.net>
Fri, 2 Sep 2022 13:38:03 +0000 (15:38 +0200)
For single threaded poll tests call pthread_kill() from main thread so
that we are sure worker thread has finished its job and it is possible
to proceed with next test types from test suite. It was observed that on
some platforms it takes a bit longer for worker thread to exit and next
test case sees device as busy in this case.

Signed-off-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Acked-by: Magnus Karlsson <magnus.karlsson@intel.com>
Link: https://lore.kernel.org/bpf/20220901114813.16275-6-maciej.fijalkowski@intel.com
tools/testing/selftests/bpf/xskxceiver.c

index b54b844cae892b5f3b0878b9262480c211861f23..74b21ddf5a9879b6666063f651d97d45b34d8c04 100644 (file)
@@ -1345,6 +1345,11 @@ static void testapp_clean_xsk_umem(struct ifobject *ifobj)
        munmap(ifobj->umem->buffer, umem_sz);
 }
 
+static void handler(int signum)
+{
+       pthread_exit(NULL);
+}
+
 static int testapp_validate_traffic_single_thread(struct test_spec *test, struct ifobject *ifobj,
                                                  enum test_type type)
 {
@@ -1362,6 +1367,7 @@ static int testapp_validate_traffic_single_thread(struct test_spec *test, struct
        test->ifobj_rx->shared_umem = false;
        test->ifobj_tx->shared_umem = false;
 
+       signal(SIGUSR1, handler);
        /* Spawn thread */
        pthread_create(&t0, NULL, ifobj->func_ptr, test);
 
@@ -1371,6 +1377,7 @@ static int testapp_validate_traffic_single_thread(struct test_spec *test, struct
        if (pthread_barrier_destroy(&barr))
                exit_with_error(errno);
 
+       pthread_kill(t0, SIGUSR1);
        pthread_join(t0, NULL);
 
        if (test->total_steps == test->current_step || test->fail) {