projects
/
linux-block.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
f5cc9cd
)
ALSA: hda: cirrus_scodec: fix an error code
author
Dan Carpenter
<dan.carpenter@linaro.org>
Wed, 27 Sep 2023 12:44:01 +0000
(15:44 +0300)
committer
Takashi Iwai
<tiwai@suse.de>
Sat, 30 Sep 2023 07:47:17 +0000
(09:47 +0200)
The "ret" variable is zero but we should return -EINVAL.
Fixes:
2144833e7b41
("ALSA: hda: cirrus_scodec: Add KUnit test")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Richard Fitzgerald <rf@opensource.cirrus.com>
Link:
https://lore.kernel.org/r/5eea7fd5-67c8-4ed4-b5b3-b85dfb7572cc@moroto.mountain
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/pci/hda/cirrus_scodec_test.c
patch
|
blob
|
blame
|
history
diff --git
a/sound/pci/hda/cirrus_scodec_test.c
b/sound/pci/hda/cirrus_scodec_test.c
index 5eb590cd4fe2280b4f1b9535cdc291c7cf666cb8..8ae373676bd1a45b87b78b387928878bba48d4f9 100644
(file)
--- a/
sound/pci/hda/cirrus_scodec_test.c
+++ b/
sound/pci/hda/cirrus_scodec_test.c
@@
-137,8
+137,8
@@
static int cirrus_scodec_test_create_gpio(struct kunit *test)
priv->gpio_priv = dev_get_drvdata(&priv->gpio_pdev->dev);
if (!priv->gpio_priv) {
platform_device_put(priv->gpio_pdev);
- KUNIT_FAIL(test, "Failed to get gpio private data
: %d\n", ret
);
- return
ret
;
+ KUNIT_FAIL(test, "Failed to get gpio private data
\n"
);
+ return
-EINVAL
;
}
return 0;