projects
/
linux-block.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
2c021b4
)
hwmon: (ltc4282) avoid repeated register write
author
Nuno Sá
<nuno.sa@analog.com>
Wed, 11 Jun 2025 16:26:12 +0000
(17:26 +0100)
committer
Guenter Roeck
<linux@roeck-us.net>
Mon, 16 Jun 2025 13:30:58 +0000
(06:30 -0700)
The fault enabled bits were being mistankenly enabled twice in case the FW
property is present. Remove one of the writes.
Fixes:
cbc29538dbf7
("hwmon: Add driver for LTC4282")
Signed-off-by: Nuno Sá <nuno.sa@analog.com>
Link:
https://lore.kernel.org/r/20250611-fix-ltc4282-repetead-write-v1-1-fe46edd08cf1@analog.com
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
drivers/hwmon/ltc4282.c
patch
|
blob
|
blame
|
history
diff --git
a/drivers/hwmon/ltc4282.c
b/drivers/hwmon/ltc4282.c
index 7f38d269623965c22424dea837ff451bb880f81e..f607fe8f793702da534902d3c3878581ac2bca1f 100644
(file)
--- a/
drivers/hwmon/ltc4282.c
+++ b/
drivers/hwmon/ltc4282.c
@@
-1511,13
+1511,6
@@
static int ltc4282_setup(struct ltc4282_state *st, struct device *dev)
return ret;
}
- if (device_property_read_bool(dev, "adi,fault-log-enable")) {
- ret = regmap_set_bits(st->map, LTC4282_ADC_CTRL,
- LTC4282_FAULT_LOG_EN_MASK);
- if (ret)
- return ret;
- }
-
if (device_property_read_bool(dev, "adi,fault-log-enable")) {
ret = regmap_set_bits(st->map, LTC4282_ADC_CTRL, LTC4282_FAULT_LOG_EN_MASK);
if (ret)