dmaengine: fsl-edma: Annotate struct struct fsl_edma_engine with __counted_by
authorKees Cook <keescook@chromium.org>
Tue, 3 Oct 2023 23:27:56 +0000 (16:27 -0700)
committerVinod Koul <vkoul@kernel.org>
Wed, 4 Oct 2023 07:21:02 +0000 (12:51 +0530)
Prepare for the coming implementation by GCC and Clang of the __counted_by
attribute. Flexible array members annotated with __counted_by can have
their accesses bounds-checked at run-time via CONFIG_UBSAN_BOUNDS (for
array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family
functions).

As found with Coccinelle[1], add __counted_by for struct struct fsl_edma_engine.

Cc: Vinod Koul <vkoul@kernel.org>
Cc: dmaengine@vger.kernel.org
Link: https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci
Signed-off-by: Kees Cook <keescook@chromium.org>
Reviewed-by: "Gustavo A. R. Silva" <gustavoars@kernel.org>
Link: https://lore.kernel.org/r/20231003232704.work.596-kees@kernel.org
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/dma/fsl-edma-common.h

index 3cc0cc8fc2d05d41b953ae55a4b38dab235eccfe..2b55c2e399f9128189851bafc76b21e278f7faec 100644 (file)
@@ -213,7 +213,7 @@ struct fsl_edma_engine {
        bool                    big_endian;
        struct edma_regs        regs;
        u64                     chan_masked;
-       struct fsl_edma_chan    chans[];
+       struct fsl_edma_chan    chans[] __counted_by(n_chans);
 };
 
 #define edma_read_tcdreg(chan, __name)                         \