projects
/
linux-block.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
6aa35ce
)
mmc: mmci: Drop unnecessary clear of variant->qcom_dml flag
author
Ulf Hansson
<ulf.hansson@linaro.org>
Wed, 6 Mar 2019 14:04:52 +0000
(15:04 +0100)
committer
Ulf Hansson
<ulf.hansson@linaro.org>
Mon, 15 Apr 2019 09:55:54 +0000
(11:55 +0200)
There's no point clearing the variant flag in case the qcom variant fails
to setup DMA. This is because if mmci_dma_setup() fails, then the use_dma
flag remains set to false, which leads to mmci using PIO mode and not DMA.
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
drivers/mmc/host/mmci_qcom_dml.c
patch
|
blob
|
blame
|
history
diff --git
a/drivers/mmc/host/mmci_qcom_dml.c
b/drivers/mmc/host/mmci_qcom_dml.c
index 25d0a75533eaab233eef9343070c95373f0d4842..b942d4aeeb77403f2521ba4b1f09e731f766e2fe 100644
(file)
--- a/
drivers/mmc/host/mmci_qcom_dml.c
+++ b/
drivers/mmc/host/mmci_qcom_dml.c
@@
-133,7
+133,6
@@
static int qcom_dma_setup(struct mmci_host *host)
producer_id = of_get_dml_pipe_index(np, "rx");
if (producer_id < 0 || consumer_id < 0) {
- host->variant->qcom_dml = false;
mmci_dmae_release(host);
return -EINVAL;
}