drm/ast: Use drm_aperture_remove_conflicting_pci_framebuffers
authorDaniel Vetter <daniel.vetter@ffwll.ch>
Wed, 11 Jan 2023 15:41:02 +0000 (16:41 +0100)
committerThomas Zimmermann <tzimmermann@suse.de>
Tue, 4 Apr 2023 12:55:50 +0000 (14:55 +0200)
It's just open coded and matches.

Note that Thomas said that his version apparently failed for some
reason, but hey maybe we should try again.

Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Dave Airlie <airlied@redhat.com>
Cc: Thomas Zimmermann <tzimmermann@suse.de>
Cc: Javier Martinez Canillas <javierm@redhat.com>
Cc: Helge Deller <deller@gmx.de>
Cc: linux-fbdev@vger.kernel.org
Tested-by: Thomas Zimmmermann <tzimmermann@suse.de>
Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Link: https://patchwork.freedesktop.org/patch/msgid/20230111154112.90575-1-daniel.vetter@ffwll.ch
drivers/gpu/drm/ast/ast_drv.c

index 3a7af6d5aa798aaa13626bc1d5096859332d8e93..e1224ef4ad83d4d41d70cba06d0d60bbf159643a 100644 (file)
@@ -89,27 +89,13 @@ static const struct pci_device_id ast_pciidlist[] = {
 
 MODULE_DEVICE_TABLE(pci, ast_pciidlist);
 
-static int ast_remove_conflicting_framebuffers(struct pci_dev *pdev)
-{
-       bool primary = false;
-       resource_size_t base, size;
-
-       base = pci_resource_start(pdev, 0);
-       size = pci_resource_len(pdev, 0);
-#ifdef CONFIG_X86
-       primary = pdev->resource[PCI_ROM_RESOURCE].flags & IORESOURCE_ROM_SHADOW;
-#endif
-
-       return drm_aperture_remove_conflicting_framebuffers(base, size, primary, &ast_driver);
-}
-
 static int ast_pci_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
 {
        struct ast_device *ast;
        struct drm_device *dev;
        int ret;
 
-       ret = ast_remove_conflicting_framebuffers(pdev);
+       ret = drm_aperture_remove_conflicting_pci_framebuffers(pdev, &ast_driver);
        if (ret)
                return ret;