drm/msm/hdmi: simplify code in pll_get_integloop_gain
authorRex Nie <rex.nie@jaguarmicro.com>
Tue, 12 Nov 2024 07:41:00 +0000 (15:41 +0800)
committerAbhinav Kumar <quic_abhinavk@quicinc.com>
Tue, 3 Dec 2024 02:59:01 +0000 (18:59 -0800)
In pll_get_integloop_gain(), digclk_divsel=1 or 2, base=63 or 196ULL,
so the base may be 63, 126, 196, 392. The condition base <= 2046
always true.

Fixes: caedbf17c48d ("drm/msm: add msm8998 hdmi phy/pll support")
Signed-off-by: Rex Nie <rex.nie@jaguarmicro.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
Patchwork: https://patchwork.freedesktop.org/patch/624153/
Link: https://lore.kernel.org/r/20241112074101.2206-1-rex.nie@jaguarmicro.com
Signed-off-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
drivers/gpu/drm/msm/hdmi/hdmi_phy_8998.c

index a719fd33d9d8d535a1a974c28d5ec53d470e1ea6..33bb48ae58a2da13b7e90ff419c6e05fec1466af 100644 (file)
@@ -137,7 +137,7 @@ static inline u32 pll_get_integloop_gain(u64 frac_start, u64 bclk, u32 ref_clk,
 
        base <<= (digclk_divsel == 2 ? 1 : 0);
 
-       return (base <= 2046 ? base : 2046);
+       return base;
 }
 
 static inline u32 pll_get_pll_cmp(u64 fdata, unsigned long ref_clk)