ASoC: SOF: ipc4-topology: remove shadowed variable
authorPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Tue, 2 Apr 2024 14:59:59 +0000 (09:59 -0500)
committerMark Brown <broonie@kernel.org>
Tue, 2 Apr 2024 16:14:29 +0000 (17:14 +0100)
Cppcheck reports this:

sound/soc/sof/ipc4-topology.c:569:23: style: Local variable 'sdev'
shadows outer variable [shadowVariable]
  struct snd_sof_dev *sdev = snd_soc_component_get_drvdata(scomp);
                      ^
sound/soc/sof/ipc4-topology.c:512:22: note: Shadowed declaration
 struct snd_sof_dev *sdev = snd_soc_component_get_drvdata(scomp);
                     ^
sound/soc/sof/ipc4-topology.c:569:23: note: Shadow variable
  struct snd_sof_dev *sdev = snd_soc_component_get_drvdata(scomp);
                      ^

Remove shadowed variable.

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Link: https://msgid.link/r/20240402145959.172619-5-pierre-louis.bossart@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/sof/ipc4-topology.c

index da4a83afb87a8a2c4163f34a8d6e9993b92bde77..651bff2122a3bf9c960ade3d2720db05d641477f 100644 (file)
@@ -566,7 +566,6 @@ static int sof_ipc4_widget_setup_comp_dai(struct snd_sof_widget *swidget)
        switch (ipc4_copier->dai_type) {
        case SOF_DAI_INTEL_ALH:
        {
-               struct snd_sof_dev *sdev = snd_soc_component_get_drvdata(scomp);
                struct sof_ipc4_alh_configuration_blob *blob;
                struct snd_soc_dapm_path *p;
                struct snd_sof_widget *w;