ring-buffer: Allocate sub-buffers with __GFP_COMP
authorVincent Donnefort <vdonnefort@google.com>
Fri, 10 May 2024 14:04:30 +0000 (15:04 +0100)
committerSteven Rostedt (Google) <rostedt@goodmis.org>
Mon, 13 May 2024 22:09:55 +0000 (18:09 -0400)
In preparation for the ring-buffer memory mapping, allocate compound
pages for the ring-buffer sub-buffers to enable us to map them to
user-space with vm_insert_pages().

Link: https://lore.kernel.org/linux-trace-kernel/20240510140435.3550353-2-vdonnefort@google.com
Acked-by: David Hildenbrand <david@redhat.com>
Signed-off-by: Vincent Donnefort <vdonnefort@google.com>
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
kernel/trace/ring_buffer.c

index 6511dc3a00da841bc79554973636056b51c600ff..a1e011733f6a200b69beb9ff44a216e24b54f239 100644 (file)
@@ -1524,7 +1524,7 @@ static int __rb_allocate_pages(struct ring_buffer_per_cpu *cpu_buffer,
                list_add(&bpage->list, pages);
 
                page = alloc_pages_node(cpu_to_node(cpu_buffer->cpu),
-                                       mflags | __GFP_ZERO,
+                                       mflags | __GFP_COMP | __GFP_ZERO,
                                        cpu_buffer->buffer->subbuf_order);
                if (!page)
                        goto free_pages;
@@ -1609,7 +1609,7 @@ rb_allocate_cpu_buffer(struct trace_buffer *buffer, long nr_pages, int cpu)
 
        cpu_buffer->reader_page = bpage;
 
-       page = alloc_pages_node(cpu_to_node(cpu), GFP_KERNEL | __GFP_ZERO,
+       page = alloc_pages_node(cpu_to_node(cpu), GFP_KERNEL | __GFP_COMP | __GFP_ZERO,
                                cpu_buffer->buffer->subbuf_order);
        if (!page)
                goto fail_free_reader;
@@ -5579,7 +5579,7 @@ ring_buffer_alloc_read_page(struct trace_buffer *buffer, int cpu)
                goto out;
 
        page = alloc_pages_node(cpu_to_node(cpu),
-                               GFP_KERNEL | __GFP_NORETRY | __GFP_ZERO,
+                               GFP_KERNEL | __GFP_NORETRY | __GFP_COMP | __GFP_ZERO,
                                cpu_buffer->buffer->subbuf_order);
        if (!page) {
                kfree(bpage);