selftests: bpf: fix duplicate selftests in cpumask_success.

The BPF cpumask selftests are currently run twice in
test_progs/cpumask.c, once by traversing cpumask_success_testcases, and
once by invoking RUN_TESTS(cpumask_success). Remove the invocation of
RUN_TESTS to properly run the selftests only once.

Now that the tests are run only through cpumask_success_testscases, add
to it the missing test_refcount_null_tracking testcase. Also remove the
__success annotation from it, since it is now loaded and invoked by the
runner.

Signed-off-by: Emil Tsalapatis (Meta) <emil@etsalapatis.com>
Acked-by: Hou Tao <houtao1@huawei.com>
Link: https://lore.kernel.org/r/20250309230427.26603-5-emil@etsalapatis.com
Signed-off-by: Alexei Starovoitov <ast@kernel.org>

diff --git a/tools/testing/selftests/bpf/prog_tests/cpumask.c b/tools/testing/selftests/bpf/prog_tests/cpumask.c
index 9b09beba988b464bca8ad1f0a214085831f3565f..6c45330a5ca31d931f33cb861b77c5d118703613 100644 (file)
--- a/tools/testing/selftests/bpf/prog_tests/cpumask.c
+++ b/tools/testing/selftests/bpf/prog_tests/cpumask.c
@@ -25,6 +25,7 @@ static const char * const cpumask_success_testcases[] = {
        "test_global_mask_nested_deep_rcu",
        "test_global_mask_nested_deep_array_rcu",
        "test_cpumask_weight",
+       "test_refcount_null_tracking",
        "test_populate_reject_small_mask",
        "test_populate_reject_unaligned",
        "test_populate",
@@ -81,6 +82,5 @@ void test_cpumask(void)
                verify_success(cpumask_success_testcases[i]);
        }
 
-       RUN_TESTS(cpumask_success);
        RUN_TESTS(cpumask_failure);
 }

diff --git a/tools/testing/selftests/bpf/progs/cpumask_success.c b/tools/testing/selftests/bpf/progs/cpumask_success.c
index 91a5357769a8b5ec82194a34c83bfbcfe737ae52..0e04c31b91c0c0078ec2e5045033f7e25d585311 100644 (file)
--- a/tools/testing/selftests/bpf/progs/cpumask_success.c
+++ b/tools/testing/selftests/bpf/progs/cpumask_success.c
@@ -749,7 +749,6 @@ out:
 }
 
 SEC("tp_btf/task_newtask")
-__success
 int BPF_PROG(test_refcount_null_tracking, struct task_struct *task, u64 clone_flags)
 {
        struct bpf_cpumask *mask1, *mask2;