staging: most: hdm-usb: Use setup_timer
authorMuhammad Falak R Wani <falakreyaz@gmail.com>
Sat, 24 Oct 2015 02:15:44 +0000 (07:45 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 25 Oct 2015 02:09:03 +0000 (19:09 -0700)
Use the timer API function setup_timer instead of init_timer, removing
the structure field assignments.

<smpl>

@timer@
expression e1,e2,e3,fn_ptr;
@@
-init_timer(&e1);
+setup_timer(&e1, fn_ptr, e2);
... when != fn_ptr = e3
-e1.function = fn_ptr;
-e1.data = e2;

</smpl>

Signed-off-by: Muhammad Falak R Wani <falakreyaz@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/most/hdm-usb/hdm_usb.c

index b5fb1a781ae1526f01b8919921fe350e2e6360c3..41690f801fb8c6af9ebf636da98b4128241c9970 100644 (file)
@@ -1239,11 +1239,10 @@ hdm_probe(struct usb_interface *interface, const struct usb_device_id *id)
        num_endpoints = usb_iface_desc->desc.bNumEndpoints;
        mutex_init(&mdev->io_mutex);
        INIT_WORK(&mdev->poll_work_obj, wq_netinfo);
-       init_timer(&mdev->link_stat_timer);
+       setup_timer(&mdev->link_stat_timer, link_stat_timer_handler,
+                   (unsigned long)mdev);
 
        mdev->usb_device = usb_dev;
-       mdev->link_stat_timer.function = link_stat_timer_handler;
-       mdev->link_stat_timer.data = (unsigned long)mdev;
        mdev->link_stat_timer.expires = jiffies + (2 * HZ);
 
        mdev->iface.mod = hdm_usb_fops.owner;