net: ipa: drop an error message
authorAlex Elder <elder@linaro.org>
Mon, 9 Nov 2020 16:56:35 +0000 (10:56 -0600)
committerJakub Kicinski <kuba@kernel.org>
Wed, 11 Nov 2020 22:07:00 +0000 (14:07 -0800)
There is no need for gsi_modem_channel_halt() to report an error,
because gsi_generic_command() will already have done that if the
command times out.  So get rid of the extra message.

Signed-off-by: Alex Elder <elder@linaro.org>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ipa/gsi.c

index 961a11d4fb2701e26affa12a18f509f6cd605e2f..3a5998a037dab9126bc6abe1a44390569ec1f671 100644 (file)
@@ -1661,12 +1661,7 @@ static int gsi_modem_channel_alloc(struct gsi *gsi, u32 channel_id)
 
 static void gsi_modem_channel_halt(struct gsi *gsi, u32 channel_id)
 {
-       int ret;
-
-       ret = gsi_generic_command(gsi, channel_id, GSI_GENERIC_HALT_CHANNEL);
-       if (ret)
-               dev_err(gsi->dev, "error %d halting modem channel %u\n",
-                       ret, channel_id);
+       (void)gsi_generic_command(gsi, channel_id, GSI_GENERIC_HALT_CHANNEL);
 }
 
 /* Setup function for channels */