mm: page_vma_mapped_walk(): use goto instead of while (1)
authorHugh Dickins <hughd@google.com>
Fri, 25 Jun 2021 01:39:20 +0000 (18:39 -0700)
committerSasha Levin <sashal@kernel.org>
Wed, 30 Jun 2021 12:47:28 +0000 (08:47 -0400)
commit 474466301dfd8b39a10c01db740645f3f7ae9a28 upstream.

page_vma_mapped_walk() cleanup: add a label this_pte, matching next_pte,
and use "goto this_pte", in place of the "while (1)" loop at the end.

Link: https://lkml.kernel.org/r/a52b234a-851-3616-2525-f42736e8934@google.com
Signed-off-by: Hugh Dickins <hughd@google.com>
Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
Cc: Alistair Popple <apopple@nvidia.com>
Cc: Matthew Wilcox <willy@infradead.org>
Cc: Peter Xu <peterx@redhat.com>
Cc: Ralph Campbell <rcampbell@nvidia.com>
Cc: Wang Yugui <wangyugui@e16-tech.com>
Cc: Will Deacon <will@kernel.org>
Cc: Yang Shi <shy828301@gmail.com>
Cc: Zi Yan <ziy@nvidia.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
mm/page_vma_mapped.c

index 3c3a7cb2de85ef773a8d7a29d0e61bbe28cf86c9..cb43affe6c76b4595020916c52bb8da7b7c6734d 100644 (file)
@@ -143,6 +143,7 @@ bool page_vma_mapped_walk(struct page_vma_mapped_walk *pvmw)
 {
        struct mm_struct *mm = pvmw->vma->vm_mm;
        struct page *page = pvmw->page;
+       unsigned long end;
        pgd_t *pgd;
        p4d_t *p4d;
        pud_t *pud;
@@ -232,10 +233,7 @@ restart:
                }
                if (!map_pte(pvmw))
                        goto next_pte;
-       }
-       while (1) {
-               unsigned long end;
-
+this_pte:
                if (check_pte(pvmw))
                        return true;
 next_pte:
@@ -264,6 +262,7 @@ next_pte:
                        pvmw->ptl = pte_lockptr(mm, pvmw->pmd);
                        spin_lock(pvmw->ptl);
                }
+               goto this_pte;
        }
 }