net: usb: lan78xx: Fix return value handling in lan78xx_set_features
authorOleksij Rempel <o.rempel@pengutronix.de>
Mon, 9 Dec 2024 13:07:46 +0000 (14:07 +0100)
committerJakub Kicinski <kuba@kernel.org>
Wed, 11 Dec 2024 02:50:58 +0000 (18:50 -0800)
Update `lan78xx_set_features` to correctly return the result of
`lan78xx_write_reg`. This ensures that errors during register writes
are propagated to the caller.

Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Link: https://patch.msgid.link/20241209130751.703182-7-o.rempel@pengutronix.de
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/usb/lan78xx.c

index 442b6ee2dd46174ffbe5d9f1c13b3b1214207970..71f8176210c93b3e6fb74ccd18dfbf876a5d6964 100644 (file)
@@ -2822,9 +2822,7 @@ static int lan78xx_set_features(struct net_device *netdev,
 
        spin_unlock_irqrestore(&pdata->rfe_ctl_lock, flags);
 
-       lan78xx_write_reg(dev, RFE_CTL, pdata->rfe_ctl);
-
-       return 0;
+       return lan78xx_write_reg(dev, RFE_CTL, pdata->rfe_ctl);
 }
 
 static void lan78xx_deferred_vlan_write(struct work_struct *param)