devcoredump: Define 'struct bin_attribute' through macro
authorThomas Weißschuh <linux@weissschuh.net>
Tue, 14 Jan 2025 21:44:58 +0000 (22:44 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 15 Jan 2025 17:30:57 +0000 (18:30 +0100)
The macro saves some lines of code and simplifies the constification of
the attribute.

Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
Link: https://lore.kernel.org/r/20250114-sysfs-const-bin_attr-devcoredump-v1-1-fa93be30efae@weissschuh.net
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/base/devcoredump.c

index 2a0e0b2fdb98dab89c8c59a24e5b18b51b46cee1..4b1f7a6cee52769028c7ee9503dbf0428f521c35 100644 (file)
@@ -132,12 +132,8 @@ static ssize_t devcd_data_write(struct file *filp, struct kobject *kobj,
        return count;
 }
 
-static struct bin_attribute devcd_attr_data = {
-       .attr = { .name = "data", .mode = S_IRUSR | S_IWUSR, },
-       .size = 0,
-       .read = devcd_data_read,
-       .write = devcd_data_write,
-};
+static struct bin_attribute devcd_attr_data =
+       __BIN_ATTR(data, 0600, devcd_data_read, devcd_data_write, 0);
 
 static struct bin_attribute *devcd_dev_bin_attrs[] = {
        &devcd_attr_data, NULL,