nfp flower action: Modified to use VLAN helper functions
authorManish Kurup <kurup.manish@gmail.com>
Tue, 7 Nov 2017 20:48:45 +0000 (15:48 -0500)
committerDavid S. Miller <davem@davemloft.net>
Fri, 10 Nov 2017 06:32:20 +0000 (15:32 +0900)
Modified netronome nfp flower action to use VLAN helper functions instead
of accessing/referencing TC act_vlan private structures directly.

Reviewed-by: Pieter Jansen van Vuuren <pieter.jansenvanvuuren@netronome.com>
Signed-off-by: Manish Kurup <manish.kurup@verizon.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/netronome/nfp/flower/action.c

index de64cedf8b26448d1b003bc2159fb0a7566dbbdb..c1c595f8bb87dbb4eda234fb60641dad8dceace3 100644 (file)
@@ -58,7 +58,6 @@ nfp_fl_push_vlan(struct nfp_fl_push_vlan *push_vlan,
                 const struct tc_action *action)
 {
        size_t act_size = sizeof(struct nfp_fl_push_vlan);
-       struct tcf_vlan *vlan = to_vlan(action);
        u16 tmp_push_vlan_tci;
 
        push_vlan->head.jump_id = NFP_FL_ACTION_OPCODE_PUSH_VLAN;
@@ -67,8 +66,8 @@ nfp_fl_push_vlan(struct nfp_fl_push_vlan *push_vlan,
        push_vlan->vlan_tpid = tcf_vlan_push_proto(action);
 
        tmp_push_vlan_tci =
-               FIELD_PREP(NFP_FL_PUSH_VLAN_PRIO, vlan->tcfv_push_prio) |
-               FIELD_PREP(NFP_FL_PUSH_VLAN_VID, vlan->tcfv_push_vid) |
+               FIELD_PREP(NFP_FL_PUSH_VLAN_PRIO, tcf_vlan_push_prio(action)) |
+               FIELD_PREP(NFP_FL_PUSH_VLAN_VID, tcf_vlan_push_vid(action)) |
                NFP_FL_PUSH_VLAN_CFI;
        push_vlan->vlan_tci = cpu_to_be16(tmp_push_vlan_tci);
 }