ASoC: SOF: ipc-msg-injector: Fix reversed if statement
authorDan Carpenter <dan.carpenter@oracle.com>
Thu, 2 Jun 2022 09:09:35 +0000 (12:09 +0300)
committerMark Brown <broonie@kernel.org>
Mon, 6 Jun 2022 11:31:25 +0000 (12:31 +0100)
This if statement is reversed.  In fact, the condition can just be
deleted because writing zero bytes is a no-op.

Fixes: 066c67624d8c ("ASoC: SOF: ipc-msg-injector: Add support for IPC4 messages")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
Link: https://lore.kernel.org/r/Yph+T3PpGCdPsEDj@kili
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/sof/sof-client-ipc-msg-injector.c

index 030cb97d7713e8a57abe39c643e20f98a2801ba7..6bdfa527b7f76b39c4fd04d3d0fdabe9f521c48e 100644 (file)
@@ -200,16 +200,14 @@ static ssize_t sof_msg_inject_ipc4_dfs_write(struct file *file,
                return -EFAULT;
 
        count -= size;
-       if (!count) {
-               /* Copy the payload */
-               size = simple_write_to_buffer(ipc4_msg->data_ptr,
-                                             priv->max_msg_size, ppos, buffer,
-                                             count);
-               if (size < 0)
-                       return size;
-               if (size != count)
-                       return -EFAULT;
-       }
+       /* Copy the payload */
+       size = simple_write_to_buffer(ipc4_msg->data_ptr,
+                                     priv->max_msg_size, ppos, buffer,
+                                     count);
+       if (size < 0)
+               return size;
+       if (size != count)
+               return -EFAULT;
 
        ipc4_msg->data_size = count;