assoc_array: fix the return value in assoc_array_insert_mid_shortcut()

Returning the edit variable is redundant because it is dereferenced right
before it is returned.  It would be better to return true.

Found by Linux Verification Center (linuxtesting.org) with Svace.

Link: https://lkml.kernel.org/r/20240307071717.5318-1-r.smirnov@omp.ru
Signed-off-by: Roman Smirnov <r.smirnov@omp.ru>
Reviewed-by: Sergey Shtylyov <s.shtylyov@omp.ru>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

diff --git a/lib/assoc_array.c b/lib/assoc_array.c
index ca0b4f360c1a0be47fc7194b43599afa0f828342..388e656ac9743dca9913b1dc09f88040e206228c 100644 (file)
--- a/lib/assoc_array.c
+++ b/lib/assoc_array.c
@@ -938,7 +938,7 @@ static bool assoc_array_insert_mid_shortcut(struct assoc_array_edit *edit,
                edit->leaf_p = &new_n0->slots[0];
 
        pr_devel("<--%s() = ok [split shortcut]\n", __func__);
-       return edit;
+       return true;
 }
 
 /**