drm/cirrus: Use virtual encoder and connector types
authorThomas Zimmermann <tzimmermann@suse.de>
Tue, 29 Oct 2024 14:34:23 +0000 (15:34 +0100)
committerThomas Zimmermann <tzimmermann@suse.de>
Tue, 26 Nov 2024 13:19:57 +0000 (14:19 +0100)
The cirrus driver only works on emulated Cirrus hardware. Use the
correct types for encoder and connector.

As a side effect, the connector has no longer an EDID property. But
neither cirrus emulation nor driver provide any EDID data, so it
makes sense to not pretend that there could be one.

v2:
- mention removed EDID property in commit description (Dmitry)

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Acked-by: Gerd Hoffmann <kraxel@redhat.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20241029143928.208349-2-tzimmermann@suse.de
drivers/gpu/drm/tiny/cirrus.c

index afd29b3df2b51ce9fc19803709d66f3059b83eed..85af7404e726ceb63fb49ca7a4b6ad0448f7ac2d 100644 (file)
@@ -587,14 +587,14 @@ static int cirrus_pipe_init(struct cirrus_device *cirrus)
 
        encoder = &cirrus->encoder;
        ret = drm_encoder_init(dev, encoder, &cirrus_encoder_funcs,
-                              DRM_MODE_ENCODER_DAC, NULL);
+                              DRM_MODE_ENCODER_VIRTUAL, NULL);
        if (ret)
                return ret;
        encoder->possible_crtcs = drm_crtc_mask(crtc);
 
        connector = &cirrus->connector;
        ret = drm_connector_init(dev, connector, &cirrus_connector_funcs,
-                                DRM_MODE_CONNECTOR_VGA);
+                                DRM_MODE_CONNECTOR_VIRTUAL);
        if (ret)
                return ret;
        drm_connector_helper_add(connector, &cirrus_connector_helper_funcs);