net: phy: realtek: use __set_bit() in rtl8211f_led_hw_control_get()
authorMichael Klein <michael@fossekall.de>
Sun, 4 May 2025 17:29:15 +0000 (19:29 +0200)
committerPaolo Abeni <pabeni@redhat.com>
Tue, 6 May 2025 11:31:27 +0000 (13:31 +0200)
rtl8211f_led_hw_control_get() does not need atomic bit operations,
replace set_bit() by __set_bit().

Signed-off-by: Michael Klein <michael@fossekall.de>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Link: https://patch.msgid.link/20250504172916.243185-6-michael@fossekall.de
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
drivers/net/phy/realtek/realtek_main.c

index e01b13a9b5c3e76cb2c0c5de832683a2c1a7c3b4..e26098a2ff27b6a66a63bd516a7199dc1fc83f83 100644 (file)
@@ -659,17 +659,17 @@ static int rtl8211f_led_hw_control_get(struct phy_device *phydev, u8 index,
        val &= RTL8211F_LEDCR_MASK;
 
        if (val & RTL8211F_LEDCR_LINK_10)
-               set_bit(TRIGGER_NETDEV_LINK_10, rules);
+               __set_bit(TRIGGER_NETDEV_LINK_10, rules);
 
        if (val & RTL8211F_LEDCR_LINK_100)
-               set_bit(TRIGGER_NETDEV_LINK_100, rules);
+               __set_bit(TRIGGER_NETDEV_LINK_100, rules);
 
        if (val & RTL8211F_LEDCR_LINK_1000)
-               set_bit(TRIGGER_NETDEV_LINK_1000, rules);
+               __set_bit(TRIGGER_NETDEV_LINK_1000, rules);
 
        if (val & RTL8211F_LEDCR_ACT_TXRX) {
-               set_bit(TRIGGER_NETDEV_RX, rules);
-               set_bit(TRIGGER_NETDEV_TX, rules);
+               __set_bit(TRIGGER_NETDEV_RX, rules);
+               __set_bit(TRIGGER_NETDEV_TX, rules);
        }
 
        return 0;