projects
/
linux-block.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
0a8f5f4
)
ALSA: hda: tas2781-spi: Delete some dead code
author
Dan Carpenter
<dan.carpenter@linaro.org>
Wed, 22 Jan 2025 07:18:06 +0000
(10:18 +0300)
committer
Takashi Iwai
<tiwai@suse.de>
Wed, 22 Jan 2025 08:28:24 +0000
(09:28 +0100)
The scnprintf() function never returns negatives. And it won't return
zero here either, plus if it did we'd need to fix the error code.
Delete this dead code.
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Link:
https://patch.msgid.link/d57ded9e-9969-4922-8347-67b758499483@stanley.mountain
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/pci/hda/tas2781_hda_spi.c
patch
|
blob
|
blame
|
history
diff --git
a/sound/pci/hda/tas2781_hda_spi.c
b/sound/pci/hda/tas2781_hda_spi.c
index 5be71b538ce0e53c2433139f9f4592ee78e8b25d..02794fd6003d9b63872b23a5cea5a7fe06737156 100644
(file)
--- a/
sound/pci/hda/tas2781_hda_spi.c
+++ b/
sound/pci/hda/tas2781_hda_spi.c
@@
-274,13
+274,9
@@
static int tascodec_spi_init(struct tasdevice_priv *tas_priv,
*/
guard(mutex)(&tas_priv->codec_lock);
-
ret =
scnprintf(tas_priv->rca_binaryname,
+ scnprintf(tas_priv->rca_binaryname,
sizeof(tas_priv->rca_binaryname), "%sRCA%d.bin",
tas_priv->dev_name, tas_priv->index);
- if (ret <= 0) {
- dev_err(tas_priv->dev, "rca name err:0x%08x\n", ret);
- return ret;
- }
crc8_populate_msb(tas_priv->crc8_lkp_tbl, TASDEVICE_CRC8_POLYNOMIAL);
tas_priv->codec = codec;
ret = request_firmware_nowait(module, FW_ACTION_UEVENT,