remoteproc/mediatek: fix invalid use of sizeof in scp_ipi_init()
authorWei Yongjun <weiyongjun1@huawei.com>
Sat, 9 May 2020 08:42:37 +0000 (08:42 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 24 Jun 2020 15:48:42 +0000 (17:48 +0200)
[ Upstream commit 8096f80a5c09b716be207eb042c4e40d6cdefbd2 ]

sizeof() when applied to a pointer typed expression gives the
size of the pointer, not that of the pointed data.

Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org>
Fixes: 63c13d61eafe ("remoteproc/mediatek: add SCP support for mt8183")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Link: https://lore.kernel.org/r/20200509084237.36293-1-weiyongjun1@huawei.com
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/remoteproc/mtk_scp.c

index 2bead57c9cf9b1dfa0220c56c8231ab33ea91fb9..ac13e7b046a60ea8b3dc54f7b8c80ebe5014a619 100644 (file)
@@ -132,8 +132,8 @@ static int scp_ipi_init(struct mtk_scp *scp)
                (struct mtk_share_obj __iomem *)(scp->sram_base + recv_offset);
        scp->send_buf =
                (struct mtk_share_obj __iomem *)(scp->sram_base + send_offset);
-       memset_io(scp->recv_buf, 0, sizeof(scp->recv_buf));
-       memset_io(scp->send_buf, 0, sizeof(scp->send_buf));
+       memset_io(scp->recv_buf, 0, sizeof(*scp->recv_buf));
+       memset_io(scp->send_buf, 0, sizeof(*scp->send_buf));
 
        return 0;
 }