dmaengine: mediatek: mtk-cqdma: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.
To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new() which already returns void. Eventually after all drivers
are converted, .remove_new() is renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Link: https://lore.kernel.org/r/20230919133207.1400430-23-u.kleine-koenig@pengutronix.de
Signed-off-by: Vinod Koul <vkoul@kernel.org>

diff --git a/drivers/dma/mediatek/mtk-cqdma.c b/drivers/dma/mediatek/mtk-cqdma.c
index 324b7387b1b922d3528a2de9e38fbecac2d97d00..529100c5b9f5d2652e41ec0d68fe93efce499c2b 100644 (file)
--- a/drivers/dma/mediatek/mtk-cqdma.c
+++ b/drivers/dma/mediatek/mtk-cqdma.c
@@ -885,7 +885,7 @@ err_unregister:
        return err;
 }
 
-static int mtk_cqdma_remove(struct platform_device *pdev)
+static void mtk_cqdma_remove(struct platform_device *pdev)
 {
        struct mtk_cqdma_device *cqdma = platform_get_drvdata(pdev);
        struct mtk_cqdma_vchan *vc;
@@ -918,13 +918,11 @@ static int mtk_cqdma_remove(struct platform_device *pdev)
 
        dma_async_device_unregister(&cqdma->ddev);
        of_dma_controller_free(pdev->dev.of_node);
-
-       return 0;
 }
 
 static struct platform_driver mtk_cqdma_driver = {
        .probe = mtk_cqdma_probe,
-       .remove = mtk_cqdma_remove,
+       .remove_new = mtk_cqdma_remove,
        .driver = {
                .name           = KBUILD_MODNAME,
                .of_match_table = mtk_cqdma_match,