usb: xhci: remove obsolete sanity check debug messages
authorNiklas Neronin <niklas.neronin@linux.intel.com>
Wed, 26 Jun 2024 12:48:27 +0000 (15:48 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 27 Jun 2024 14:08:05 +0000 (16:08 +0200)
Remove debug messages that served as sanity checks during the initial
implementation phase of underrun/overrun completion codes. These checks
are now unnecessary.

Instead, improve the default debug messages for underrun/overrun events,
so that they are consistent with the reset of the completion codes.

Signed-off-by: Niklas Neronin <niklas.neronin@linux.intel.com>
Signed-off-by: Mathias Nyman <mathias.nyman@linux.intel.com>
Link: https://lore.kernel.org/r/20240626124835.1023046-14-mathias.nyman@linux.intel.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/host/xhci-ring.c

index d4e4c1c71f9019d3bd894b77ad384c730981d5e8..900bf34174f9a15ea3ea599d8bce7a83821eb645 100644 (file)
@@ -2719,18 +2719,12 @@ static int handle_tx_event(struct xhci_hcd *xhci,
                 * a Ring Overrun Event for IN Isoch endpoint or Ring
                 * Underrun Event for OUT Isoch endpoint.
                 */
-               xhci_dbg(xhci, "underrun event on endpoint\n");
-               if (!list_empty(&ep_ring->td_list))
-                       xhci_dbg(xhci, "Underrun Event for slot %u ep %d still with TDs queued?\n",
-                                slot_id, ep_index);
+               xhci_dbg(xhci, "Underrun event on slot %u ep %u\n", slot_id, ep_index);
                if (ep->skip)
                        break;
                return 0;
        case COMP_RING_OVERRUN:
-               xhci_dbg(xhci, "overrun event on endpoint\n");
-               if (!list_empty(&ep_ring->td_list))
-                       xhci_dbg(xhci, "Overrun Event for slot %u ep %d still with TDs queued?\n",
-                                slot_id, ep_index);
+               xhci_dbg(xhci, "Overrun event on slot %u ep %u\n", slot_id, ep_index);
                if (ep->skip)
                        break;
                return 0;