remoteproc: keystone: Simplify returning syscon PTR_ERR
authorKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Sat, 11 Jan 2025 18:42:49 +0000 (19:42 +0100)
committerMathieu Poirier <mathieu.poirier@linaro.org>
Wed, 15 Jan 2025 16:50:08 +0000 (09:50 -0700)
No need to store PTR_ERR into temporary, local 'ret' variable.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Link: https://lore.kernel.org/r/20250111-b4-syscon-phandle-args-remoteproc-v1-1-73ed6fafa1e3@linaro.org
Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
drivers/remoteproc/keystone_remoteproc.c

index 6e54093d1732314d234e85bf6cf7fb6f1d9bf994..83c8e568f7ce3ec3ca3a534d2566f6437e9d403a 100644 (file)
@@ -335,7 +335,6 @@ static int keystone_rproc_of_get_dev_syscon(struct platform_device *pdev,
 {
        struct device_node *np = pdev->dev.of_node;
        struct device *dev = &pdev->dev;
-       int ret;
 
        if (!of_property_read_bool(np, "ti,syscon-dev")) {
                dev_err(dev, "ti,syscon-dev property is absent\n");
@@ -344,10 +343,8 @@ static int keystone_rproc_of_get_dev_syscon(struct platform_device *pdev,
 
        ksproc->dev_ctrl =
                syscon_regmap_lookup_by_phandle(np, "ti,syscon-dev");
-       if (IS_ERR(ksproc->dev_ctrl)) {
-               ret = PTR_ERR(ksproc->dev_ctrl);
-               return ret;
-       }
+       if (IS_ERR(ksproc->dev_ctrl))
+               return PTR_ERR(ksproc->dev_ctrl);
 
        if (of_property_read_u32_index(np, "ti,syscon-dev", 1,
                                       &ksproc->boot_offset)) {