ASoC: soc-pcm: remove unneeded dev_err() for snd_soc_component_module/open()
authorKuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Mon, 28 Sep 2020 00:01:36 +0000 (09:01 +0900)
committerMark Brown <broonie@kernel.org>
Mon, 28 Sep 2020 16:01:47 +0000 (17:01 +0100)
snd_soc_component_module_get(), snd_soc_component_open() itself will
indicate error message, thus, soc_pcm_components_open() don't need to
handle it.
This patch removes these.

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Link: https://lore.kernel.org/r/87d026bwms.wl-kuninori.morimoto.gx@renesas.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/soc-pcm.c

index 070fb71fc6f61cbab38bbee3052ebdb971d47015..09e8d703a502cea2d2d94af521893011ec6e40a2 100644 (file)
@@ -614,20 +614,12 @@ static int soc_pcm_components_open(struct snd_pcm_substream *substream)
 
        for_each_rtd_components(rtd, i, component) {
                ret = snd_soc_component_module_get_when_open(component, substream);
-               if (ret < 0) {
-                       dev_err(component->dev,
-                               "ASoC: can't get module %s\n",
-                               component->name);
+               if (ret < 0)
                        break;
-               }
 
                ret = snd_soc_component_open(component, substream);
-               if (ret < 0) {
-                       dev_err(component->dev,
-                               "ASoC: can't open component %s: %d\n",
-                               component->name, ret);
+               if (ret < 0)
                        break;
-               }
        }
 
        return ret;