drm/amd/display: Fix the checking condition in dmub aux handling
authorWayne Lin <Wayne.Lin@amd.com>
Sun, 20 Apr 2025 08:29:07 +0000 (16:29 +0800)
committerAlex Deucher <alexander.deucher@amd.com>
Wed, 7 May 2025 22:17:42 +0000 (18:17 -0400)
[Why & How]
Fix the checking condition for detecting AUX_RET_ERROR_PROTOCOL_ERROR.
It was wrongly checking by "not equals to"

Reviewed-by: Ray Wu <ray.wu@amd.com>
Signed-off-by: Wayne Lin <Wayne.Lin@amd.com>
Signed-off-by: Ray Wu <ray.wu@amd.com>
Tested-by: Daniel Wheeler <daniel.wheeler@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
(cherry picked from commit 1db6c9e9b62e1a8912f0a281c941099fca678da3)
Cc: stable@vger.kernel.org
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c

index d9292da56948022425347459d21da5a37dbc4d8f..68bbe7d57773568ed7740eeb1d3022260db11fdf 100644 (file)
@@ -12749,7 +12749,7 @@ int amdgpu_dm_process_dmub_aux_transfer_sync(
                 * Transient states before tunneling is enabled could
                 * lead to this error. We can ignore this for now.
                 */
-               if (p_notify->result != AUX_RET_ERROR_PROTOCOL_ERROR) {
+               if (p_notify->result == AUX_RET_ERROR_PROTOCOL_ERROR) {
                        DRM_WARN("DPIA AUX failed on 0x%x(%d), error %d\n",
                                        payload->address, payload->length,
                                        p_notify->result);