md-cluster: fix ifnullfree.cocci warnings
authorkbuild test robot <lkp@intel.com>
Mon, 2 May 2016 15:50:16 +0000 (11:50 -0400)
committerShaohua Li <shli@fb.com>
Wed, 4 May 2016 19:39:35 +0000 (12:39 -0700)
drivers/md/bitmap.c:2049:6-11: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values.

 NULL check before some freeing functions is not needed.

 Based on checkpatch warning
 "kfree(NULL) is safe this check is probably not required"
 and kfreeaddr.cocci by Julia Lawall.

Generated by: scripts/coccinelle/free/ifnullfree.cocci

Acked-by: Guoqing Jiang <gqjiang@suse.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Shaohua Li <shli@fb.com>
drivers/md/bitmap.c

index 4a05bacd6601dfa98c1b7cd5be1240ab57a33b33..ad5a85847004f6cef2ed040c84f15709cdb3a601 100644 (file)
@@ -2076,8 +2076,7 @@ int bitmap_resize(struct bitmap *bitmap, sector_t blocks,
 
                                /* deallocate the page memory */
                                for (k = 0; k < page; k++) {
-                                       if (new_bp[k].map)
-                                               kfree(new_bp[k].map);
+                                       kfree(new_bp[k].map);
                                }
 
                                /* restore some fields from old_counts */