[SCSI] qla2xxx: fix lock imbalance
authorJiri Slaby <jslaby@suse.cz>
Tue, 16 Mar 2010 15:23:59 +0000 (16:23 +0100)
committerJames Bottomley <James.Bottomley@suse.de>
Thu, 8 Apr 2010 22:42:41 +0000 (18:42 -0400)
Stanse found that one error path in qla24xx_bsg_timeout omits to
unlock ha->hardware_lock. Fix that.

Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Acked-by: Giridhar Malavali <giridhar.malavali@qlogic.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
drivers/scsi/qla2xxx/qla_attr.c

index 359e9a71a021498ddf1211b826ac65ef9e673cec..1c7ef55966fb528db0dfc9422434cbd78ba528f8 100644 (file)
@@ -2393,6 +2393,7 @@ qla24xx_bsg_timeout(struct fc_bsg_job *bsg_job)
        return 0;
 
 done:
+       spin_unlock_irqrestore(&ha->hardware_lock, flags);
        if (bsg_job->request->msgcode == FC_BSG_HST_CT)
                kfree(sp->fcport);
        kfree(sp->ctx);