drm/msm/dsi/phy: Program clock inverters in correct register
authorKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Wed, 29 Jan 2025 11:55:04 +0000 (12:55 +0100)
committerDmitry Baryshkov <dmitry.baryshkov@linaro.org>
Wed, 26 Feb 2025 10:15:48 +0000 (12:15 +0200)
Since SM8250 all downstream sources program clock inverters in
PLL_CLOCK_INVERTERS_1 register and leave the PLL_CLOCK_INVERTERS as
reset value (0x0).  The most recent Hardware Programming Guide for 3 nm,
4 nm, 5 nm and 7 nm PHYs also mention PLL_CLOCK_INVERTERS_1.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Fixes: 1ef7c99d145c ("drm/msm/dsi: add support for 7nm DSI PHY/PLL")
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Reported-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
Patchwork: https://patchwork.freedesktop.org/patch/634489/
Link: https://lore.kernel.org/r/20250129115504.40080-1-krzysztof.kozlowski@linaro.org
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
drivers/gpu/drm/msm/dsi/phy/dsi_phy_7nm.c

index e496a95c34e92130ecdb2b3032a4779d15dcdeaf..3332399c7fd79392efeedff268a44f1a164a5326 100644 (file)
@@ -306,7 +306,7 @@ static void dsi_pll_commit(struct dsi_pll_7nm *pll, struct dsi_pll_config *confi
        writel(pll->phy->cphy_mode ? 0x00 : 0x10,
               base + REG_DSI_7nm_PHY_PLL_CMODE_1);
        writel(config->pll_clock_inverters,
-              base + REG_DSI_7nm_PHY_PLL_CLOCK_INVERTERS);
+              base + REG_DSI_7nm_PHY_PLL_CLOCK_INVERTERS_1);
 }
 
 static int dsi_pll_7nm_vco_set_rate(struct clk_hw *hw, unsigned long rate,