net: phy: marvell: use phydev->eee_cfg.eee_enabled
authorRussell King (Oracle) <rmk+kernel@armlinux.org.uk>
Thu, 5 Dec 2024 10:42:00 +0000 (10:42 +0000)
committerJakub Kicinski <kuba@kernel.org>
Sat, 7 Dec 2024 01:47:31 +0000 (17:47 -0800)
Rather than calling genphy_c45_ethtool_get_eee() to retrieve whether
EEE is enabled, use the value stored in the phy_device eee_cfg
structure.

Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Reviewed-by: Heiner Kallweit <hkallweit1@gmail.com>
Link: https://patch.msgid.link/E1tJ9J2-006LIh-Fl@rmk-PC.armlinux.org.uk
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/phy/marvell.c

index b885bc0fe6e0724f7b1e2bbf1b1e57c4e8c7c7a3..ffe223ad9e5f1883d9d2a1f4f06dc3fe06391703 100644 (file)
@@ -1550,7 +1550,6 @@ static int m88e1540_get_fld(struct phy_device *phydev, u8 *msecs)
 
 static int m88e1540_set_fld(struct phy_device *phydev, const u8 *msecs)
 {
-       struct ethtool_keee eee;
        int val, ret;
 
        if (*msecs == ETHTOOL_PHY_FAST_LINK_DOWN_OFF)
@@ -1560,8 +1559,7 @@ static int m88e1540_set_fld(struct phy_device *phydev, const u8 *msecs)
        /* According to the Marvell data sheet EEE must be disabled for
         * Fast Link Down detection to work properly
         */
-       ret = genphy_c45_ethtool_get_eee(phydev, &eee);
-       if (!ret && eee.eee_enabled) {
+       if (phydev->eee_cfg.eee_enabled) {
                phydev_warn(phydev, "Fast Link Down detection requires EEE to be disabled!\n");
                return -EBUSY;
        }