tick/sched: Remove bogus boot "safety" check
authorThomas Gleixner <tglx@linutronix.de>
Sun, 6 Dec 2020 21:12:55 +0000 (22:12 +0100)
committerThomas Gleixner <tglx@linutronix.de>
Wed, 16 Dec 2020 10:26:27 +0000 (11:26 +0100)
can_stop_idle_tick() checks whether the do_timer() duty has been taken over
by a CPU on boot. That's silly because the boot CPU always takes over with
the initial clockevent device.

But even if no CPU would have installed a clockevent and taken over the
duty then the question whether the tick on the current CPU can be stopped
or not is moot. In that case the current CPU would have no clockevent
either, so there would be nothing to keep ticking.

Remove it.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Acked-by: Frederic Weisbecker <frederic@kernel.org>
Link: https://lore.kernel.org/r/20201206212002.725238293@linutronix.de
kernel/time/tick-sched.c

index a9e68936822d4faa8045cfff80ad0375abfb628a..5fbc748f0058003e2e8867677a896c936343c715 100644 (file)
@@ -991,13 +991,6 @@ static bool can_stop_idle_tick(int cpu, struct tick_sched *ts)
                 */
                if (tick_do_timer_cpu == cpu)
                        return false;
-               /*
-                * Boot safety: make sure the timekeeping duty has been
-                * assigned before entering dyntick-idle mode,
-                * tick_do_timer_cpu is TICK_DO_TIMER_BOOT
-                */
-               if (unlikely(tick_do_timer_cpu == TICK_DO_TIMER_BOOT))
-                       return false;
 
                /* Should not happen for nohz-full */
                if (WARN_ON_ONCE(tick_do_timer_cpu == TICK_DO_TIMER_NONE))