media: rc: remove unused tx_resolution field
authorSean Young <sean@mess.org>
Sun, 30 Jun 2024 21:33:44 +0000 (22:33 +0100)
committerHans Verkuil <hverkuil-cisco@xs4all.nl>
Wed, 31 Jul 2024 09:21:56 +0000 (11:21 +0200)
The tx_resolution field is never read. In theory you can imagine this
field being useful for detecting whether the transmitter has the
resolution for the message you are trying to send, but I am not aware of
any hardware where this could be an issue.

Just remove.

Signed-off-by: Sean Young <sean@mess.org>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
drivers/media/rc/ene_ir.c
drivers/media/rc/ite-cir.c
drivers/media/rc/rc-loopback.c
include/media/rc-core.h

index 11ee21a7db8f00e56ac1b4b123fba91b6d2988c5..67722e2e47ff78e504c55054480f0619e050f093 100644 (file)
@@ -451,9 +451,6 @@ select_timeout:
                dev->rdev->max_timeout = 200000;
        }
 
-       if (dev->hw_learning_and_tx_capable)
-               dev->rdev->tx_resolution = sample_period;
-
        if (dev->rdev->timeout > dev->rdev->max_timeout)
                dev->rdev->timeout = dev->rdev->max_timeout;
        if (dev->rdev->timeout < dev->rdev->min_timeout)
index fcfadd7ea31cf300a451ca9be73547f7766f3f92..2bacecb022623e0bc2a004feb5f02c71f33ced63 100644 (file)
@@ -1380,7 +1380,6 @@ static int ite_probe(struct pnp_dev *pdev, const struct pnp_device_id
        rdev->timeout = IR_DEFAULT_TIMEOUT;
        rdev->max_timeout = 10 * IR_DEFAULT_TIMEOUT;
        rdev->rx_resolution = ITE_BAUDRATE_DIVISOR * sample_period / 1000;
-       rdev->tx_resolution = ITE_BAUDRATE_DIVISOR * sample_period / 1000;
 
        /* set up transmitter related values */
        rdev->tx_ir = ite_tx_ir;
index b356041c5c00e718dcfde82cc374681da46b1276..8288366f891fc999831fd8071e6a35cd56cd1cd9 100644 (file)
@@ -230,7 +230,6 @@ static int __init loop_init(void)
        rc->min_timeout         = 1;
        rc->max_timeout         = IR_MAX_TIMEOUT;
        rc->rx_resolution       = 1;
-       rc->tx_resolution       = 1;
        rc->s_tx_mask           = loop_set_tx_mask;
        rc->s_tx_carrier        = loop_set_tx_carrier;
        rc->s_tx_duty_cycle     = loop_set_tx_duty_cycle;
index 803349599c272bdd23c4ac50a7e1c7277b340458..d095908073ef9d788caa32e7e4d919947679cc9f 100644 (file)
@@ -127,7 +127,6 @@ struct lirc_fh {
  * @min_timeout: minimum timeout supported by device
  * @max_timeout: maximum timeout supported by device
  * @rx_resolution : resolution (in us) of input sampler
- * @tx_resolution: resolution (in us) of output sampler
  * @lirc_dev: lirc device
  * @lirc_cdev: lirc char cdev
  * @gap_start: start time for gap after timeout if non-zero
@@ -194,7 +193,6 @@ struct rc_dev {
        u32                             min_timeout;
        u32                             max_timeout;
        u32                             rx_resolution;
-       u32                             tx_resolution;
 #ifdef CONFIG_LIRC
        struct device                   lirc_dev;
        struct cdev                     lirc_cdev;